Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If type identifier for an environment is not registered, infer type from locator #23083

Merged
merged 3 commits into from
Mar 17, 2024

Conversation

karrtikr
Copy link

For #22810

...so in case of Hatch, as an explicit Hatch identifier is not available, we infer an environment is Hatch if we get it from the Hatch locator: #22779.

@karrtikr karrtikr changed the title Use locator as fallback if identifier for a environment provider is not registered Use locator as fallback if identifier for an environment is not registered Mar 16, 2024
@karrtikr karrtikr added bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary labels Mar 16, 2024
@karrtikr karrtikr changed the title Use locator as fallback if identifier for an environment is not registered If type identifier for an environment is not registered, infer type from locator Mar 16, 2024
@karrtikr karrtikr marked this pull request as ready for review March 16, 2024 23:27
@vscodenpa vscodenpa added this to the March 2024 milestone Mar 16, 2024
@karrtikr karrtikr enabled auto-merge (squash) March 16, 2024 23:29
@karrtikr karrtikr merged commit 62dc85b into main Mar 17, 2024
65 of 67 checks passed
@karrtikr karrtikr deleted the kartik/zoophagous-kangaroo branch March 17, 2024 06:14
wesm pushed a commit to posit-dev/positron that referenced this pull request Apr 5, 2024
…rom locator (microsoft/vscode-python#23083)

For microsoft/vscode-python#22810

...so in case of Hatch, as an [explicit Hatch identifier is not
available](microsoft/vscode-python#22779 (comment)),
we infer an environment is Hatch if we get it from the Hatch locator:
microsoft/vscode-python#22779.
wesm pushed a commit to posit-dev/positron that referenced this pull request Apr 8, 2024
…rom locator (microsoft/vscode-python#23083)

For microsoft/vscode-python#22810

...so in case of Hatch, as an [explicit Hatch identifier is not
available](microsoft/vscode-python#22779 (comment)),
we infer an environment is Hatch if we get it from the Hatch locator:
microsoft/vscode-python#22779.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants