-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds lang service switch #18034
Adds lang service switch #18034
Conversation
VSIX Size Comparison
React Webview Bundle Size Comparison
|
@aasimkhan30, here's another GitHub issue that is related to the concern you're pointing out. (#801). This PR was intended to add a switch to optionally set the language mode to "None" as the default, instead of MSSQL when opening editors. The new switch that is added by this PR is initially turned off, meaning that MSSQL will be the default language mode when editors are opened. |
How does #801 address the point Aasim mentions regarding opening editors with an MSSQL connection? I think in those scenarios the language mode should probably be MSSQL regardless of this setting. I think this setting is more relevant for non-connected SQL files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to do a design review on Intellisense settings and how to handle connections for new SQL documents. And how best to handle non-MSSQL compatible SQL files. This seems like part of the solution but maybe should be a little different than currently implemented.
Closing PR as we revisit the design |
This PR fixes #17298
This PR adds a new setting to the MSSQL extension that allows users to have the language mode set to none by default

New query editors that are opened when this setting is enabled, will have "None" as the chosen language

Previously saved query files that are opened when this setting is enabled, will also have "None" as the chosen language

To enable the MSSQL language mode for an editor, first click on "None" in the status bar, and then choose MSSQL as the language
