Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lewissanchez/feat/add language service switch #18033

Closed

Conversation

lewis-sanchez
Copy link
Contributor

This PR fixes #17298

This PR adds a new setting to the MSSQL extension that allows users to have the language mode set to none by default
image

New query editors that are opened when this setting is enabled, will have "None" as the chosen language
image

Previously saved query files that are opened when this setting is enabled, will also have "None" as the chosen language
image

@lewis-sanchez
Copy link
Contributor Author

Need to fix PR issues with whitespace
image

@lewis-sanchez lewis-sanchez marked this pull request as draft September 10, 2024 21:04
Copy link

VSIX Size Comparison

  • Main branch VSIX size: 11750 KB
  • PR branch VSIX size: 11750 KB
  • Size difference: $${\color{green} 0 KB \space (0\%) }$$

React Webview Bundle Size Comparison

  • Main branch bundle size: 2416 KB
  • PR branch bundle size: 2416 KB
  • Size difference: $${\color{green} 0 KB \space (0\%) }$$

Copy link

Updates to localized strings required

Please update the localized strings in the PR with following steps:

  1. Run yarn localization in the PR branch.
  2. Based on the changes,
    • If there are changes in localized strings in source code, make sure that src/localization/xliff/vscode-mssql.xlf and src/l10n/bundle.l10n.json files are updated.
    • If there are changes in localized strings in package.nls.json, make sure that src/localization/xliff/vscode-mssql.xlf is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Suggestion] Include an option to set MSSQL to none by default
1 participant