Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip present on "save as json", "save as excel", "save as CSV" buttons are not accessible with keyboard: A11y_mssql for VSCode_mssql Extension_Select top 1000 Results window_Keyboard #17875

Closed
aniketr99 opened this issue Feb 26, 2024 · 13 comments

Comments

@aniketr99
Copy link

aniketr99 commented Feb 26, 2024

GitHubTags:

#A11yTCS;#Win11;#DesktopApp;#BM_mssql for VSCode_Win32_Feb2024;#A11ySev2;#mssql for VSCode;#WCAG2.1.1;#A11yMAS;#Win32;#AINotInScope;#Keyboard;

Environment Details:

Application Name: mssql for VSCode
Operating System: Win11[23H2]
OS Build: 26016.1012
Visual studio code: 1.86.2
Extension Version: v1.22.1

Repro Steps:

  1. Open Visual studio code
  2. Tab till extension button and search for "mssql".
  3. Tab till install and move to the SQL Server button.
  4. Tab till Add Connection Button and insert the valid credentials.
  5. Tab till the database and hit enter.
  6. Tab till the System database and hit enter.
  7. Tab till the Tables and hit enter.
  8. Tab till any table under System tables and hit shift + F10
  9. Tab till Select Top 1000 and hit enter
  10. Tab till Execute Query and hit enter
  11. Tab till "Results" dropdown and hit enter
  12. Tab till "save as json", "save as excel", "save as CSV" buttons and verify whether tooltip is accessible with keyboard or not.

Actual:

Tooltip present on "save as json", "save as excel", "save as CSV" buttons are not accessible with keyboard.

Expected:

Tooltip present on "save as json", "save as excel", "save as CSV" buttons should be accessible with keyboard.

User Impact:

Keyboard users will not get about the controls if Tooltips are not appearing when controls are receiving focus.

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

Attachment
Bug_17875_Keyboard

@aniketr99 aniketr99 changed the title A11y_mssql for VSCode_mssql Extension_Select top 1000 Results window_Keyboard: Tooltip present on "save as json", "save as excel", "save as CSV" buttons are not accessible with keyboard. Tooltip present on "save as json", "save as excel", "save as CSV" buttons are not accessible with keyboard: A11y_mssql for VSCode_mssql Extension_Select top 1000 Results window_Keyboard Mar 5, 2024
@alanrenmsft
Copy link
Contributor

@aniketr99 please refer to #17201 and downgrade this one to sev3. thanks.

@aniketr99
Copy link
Author

@alanrenmsft, please join office hours to discuss this bug. Thanks!

@alanrenmsft
Copy link
Contributor

@laurennat

@aniketr99
Copy link
Author

Tags:
#Regressed:08-12-24;
Regressed the bug in the latest environment:
Issue is not fixed. Attachment is added for the reference.
Presentation1

@kburtram
Copy link
Member

kburtram commented Jan 8, 2025

@laurennat it looks like the tester said this issue isn't fixed. Could you please follow up to get this issue resolved?

@kburtram kburtram added this to the January Release 2025 milestone Jan 8, 2025
@laurenastrid1
Copy link

This has been fixed for a while, I just need a tester to verify: Image

@kburtram
Copy link
Member

kburtram commented Jan 9, 2025

@laurenastrid1 could you please follow up with the tester to get this bug and the other accessibility issue closed? And confirm that the compliance scorecard reflects these fixes? These bugs are now out of SLA and impacting our accessibility grade at this point. Thanks!

@ManishaC1
Copy link

ManishaC1 commented Jan 17, 2025

@kburtram @laurenastrid1

Verified the issue in below version of Azure Data Studio insiders. Issue is still reproducing in the environment. Please refer the attached
Version: 1.97.0-insider (user setup)
Commit: a74aabd9bb87c33b047c822aa79d265bc5f5543e
Date: 2025-01-17T05:04:33.457Z
Electron: 32.2.7
ElectronBuildId: 10660205
Chromium: 128.0.6613.186
Node.js: 20.18.1
V8: 12.8.374.38-electron.0
OS: Windows_NT x64 10.0.26100

Image

@kburtram
Copy link
Member

@laurenastrid1 could you please prioritize working the tester to get this issue resolved? Thanks!

@laurenastrid1
Copy link

laurenastrid1 commented Jan 17, 2025 via email

@laurennat
Copy link
Collaborator

This is now fixed, please email/Teams me to get the new vsix with the fix @ManishaC1

@ManishaC1
Copy link

ManishaC1 commented Jan 21, 2025

Issue is fixed.

#Closed;

VS Code version: 1.97.0-insider (user setup)
Commit: a74aabd9bb87c33b047c822aa79d265bc5f5543e
Date: 2025-01-17T05:04:33.457Z
Electron: 32.2.7
ElectronBuildId: 10660205
Chromium: 128.0.6613.186
Node.js: 20.18.1
V8: 12.8.374.38-electron.0
OS: Windows_NT x64 10.0.26100

Extension used: mssql-1.28.0 1.vsix

Image

@laurennat
Copy link
Collaborator

@ManishaC1 asked me to close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants