Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure new Proposed API is always available #14128

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Ensure new Proposed API is always available #14128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/kernels/jupyter/finder/remoteKernelFinderController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

import { injectable, inject } from 'inversify';
import { IKernelFinder, IKernelProvider } from '../../types';
import { IDisposableRegistry, IExtensionContext, IFeaturesManager } from '../../../platform/common/types';
import { IDisposableRegistry, IExtensionContext } from '../../../platform/common/types';
import {
IOldJupyterSessionManagerFactory,
IJupyterServerUriStorage,
Expand Down Expand Up @@ -49,9 +49,7 @@ export class RemoteKernelFinderController implements IRemoteKernelFinderControll
@inject(IJupyterUriProviderRegistration)
private readonly jupyterPickerRegistration: IJupyterUriProviderRegistration,
@inject(IJupyterServerProviderRegistry)
private readonly jupyterServerProviderRegistry: IJupyterServerProviderRegistry,
@inject(IFeaturesManager)
private readonly features: IFeaturesManager
private readonly jupyterServerProviderRegistry: IJupyterServerProviderRegistry
) {}
private readonly handledProviders = new WeakSet<IJupyterUriProvider>();
activate() {
Expand Down Expand Up @@ -92,9 +90,6 @@ export class RemoteKernelFinderController implements IRemoteKernelFinderControll
private mappedServers = new Set<string>();
@swallowExceptions('Handle Jupyter Provider Changes')
private async handleProviderChanges() {
if (!this.features.features.enableProposedJupyterServerProviderApi) {
return;
}
if (!this.serverUriStorage.all.length) {
// We do not have any of the previously used servers, or the data has not yet loaded.
return;
Expand Down