[azure-iot-sdk-c] Update public-preview feature to branch with fixed telemetry #9059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilyWangL
suggested changes
Nov 21, 2019
| REF d1cdf78b5160af8e08354e102a6b96395eee79e1 | ||
| SHA512 0efbfc19e5eef4831b55ded0e8d88e83194bc0f26886841ddc83405c15b7f1bae983e22dc569e22846acd78b843b9e7492883b7c502f4eed92ff80ef45a9942d | ||
| REF 1d0402c80944ec7ec24ed24314457166fef98814 | ||
| SHA512 0c3e173fa9e21efedbdb5efad155494595d1246420b590649e81a8c43e45eff4d659197d201c664a6490e5099be41546ac606c4f7d6c88e26ff32873aaff801f | ||
| HEAD_REF public-preview |
There was a problem hiding this comment.
This commit commits on the branch public-preview-merge, so need to modify HEAD_REF to public-preview-merge.
There was a problem hiding this comment.
@LilyWangL - thanks for feedback. You're correct on public-preview-merge branch. I wanted to get a CI pass of the fix as it was even though our public-preview branch was being updated in parallel. public-preview now has the changed merged into it, and I've updated our port file to point at public-preview's SHA.
I'm moving PR as ready-to-review now.
|
Note: Feature public-preview test pass with following triplets:
The feature use_prov_client has nothing to do with this change. |
grdowns
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates public-preview SDK