[json-dto] Update to v0.2.9; Switch repo; Fix license installation #9057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
PhoebeHui
reviewed
Nov 21, 2019
ports/json-dto/portfile.cmake
Outdated
| @@ -26,3 +26,4 @@ file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/lib ${CURRENT_PACKAGES_DIR}/debug) | |||
| # Handle copyright | |||
| file(COPY ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/json-dto) | |||
| file(RENAME ${CURRENT_PACKAGES_DIR}/share/json-dto/LICENSE ${CURRENT_PACKAGES_DIR}/share/json-dto/copyright) | |||
|
|
|||
There was a problem hiding this comment.
Can you also update 'Handle copyright' with following function:
file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright )
ports/json-dto/portfile.cmake
Outdated
| REF v.0.2.8 | ||
| SHA512 50a2d8d31f4cf67bdf84a58bae5f95642f4be571e8e052a48830be119d5e3c4ddbb19c5ac97fc0f8383c9958d64ec9be4ce23019c1da4f2cbf4b8ddbf23f5ad7 | ||
| REPO stiffstream/json_dto | ||
| REF v.0.2.9 |
There was a problem hiding this comment.
Could you update 'REF v.0.2.9' to 'REF 088c1fefb259267874ad9f9260f0bc1d564ddd7c # v.0.2.9'? since the commit id is more stable.
There was a problem hiding this comment.
I've applied proposed changes and updated json-dto to the latest version.
Fixes to portfile proposed by PhoebeHui.
PhoebeHui
approved these changes
Nov 21, 2019
grdowns
changed the title
grdowns
changed the title
|
Thanks for the update, @eao197! This can be merged as soon as CI goes through. Also for anyone looking at this in the future, the new GitHub repo is official AFAICT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json_dto library updated to the latest version.