[magnum-plugins] Fix basisimporter/basisimageconverter features #8939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Squareys <squareys@googlemail.com>
jherico's fork which the vcpkg port is based on does not integrate BinomialLLC/basis_universal@54304fa yet, which renamed a parameter. Signed-off-by: Squareys <squareys@googlemail.com>
The change is integrated upstream for --head builds already. Signed-off-by: Squareys <squareys@googlemail.com>
Squareys
force-pushed
the
magnum-fix-basis
branch
from
fde1cea to
81d158b
Compare
mosra
approved these changes
Nov 7, 2019
|
/azp run |
|
@PhoebeHui @JackBoosY @grdowns What the status? Looks like the rerun of the CI succeeded 🎉 Thanks in advance. |
|
Since the patch was very large (and exactly a commit from the repo), I've switched the portfile to download the diff from github instead of checking the full text in. Assuming the CI passes, LGTM & thanks for the PR! |
|
@ras0219-msft ping ... can we have this in? :) |
|
Merged! Thanks for the contributions, everyone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
This PR fixes two features of the magnum-plugins port. The maintainer, @mosra, will give this a review quickly.
Thanks!
Jonathan.