-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libplist] Update to 1.2.137 #8936
[libplist] Update to 1.2.137 #8936
Conversation
Since the port was using an unofficial port in order to exploit the msvc solution it was offering, but now it’s gone, isn’t it better to switch to the official repository? |
@cenit, thanks for helping review the changes! https://github.com/libimobiledevice-win32/libplist contains some fixes for build issues on windows, these commits doesn't merge to libimobiledevice/libplist, I reported an issue libimobiledevice/libplist#147 to ask if they have a plan to merge these fixes. Instead of making several patches now. |
Yeah, everything in libimobiledevice-win32/ is essentially a patchset to make libplist, libusbmuxd, libimobiledevice & friends compile correctly using MSVC. I maintain that unofficial fork. I've opened a couple of PRs to upstream the changes; they have been open for few years by now. The vcproj files moved to https://github.com/libimobiledevice-win32/libimobiledevice-vs if you're looking for those. @PhoebeHui is your interest just libplist or do you want the full libimobiledevice stack? |
@qmfrederik, thanks for the information! #8842 already upgrade libideviceactivation, libimobiledevice and libusbmuxd, and build them with cmake, so vcproj files doesn't need any more. So I think we're better to use libimobiledevice-win32/libplist now, and switch to libimobiledevice/libplist when the changes merged. |
/azp run |
/azp run |
/azp run |
Related to #8792
Changes:
libplist has no feature that need to test locally.