Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libplist] Update to 1.2.137 #8936

Merged
merged 4 commits into from
Jan 10, 2020

Conversation

PhoebeHui
Copy link
Contributor

Related to #8792
Changes:

  1. Upgrade version to 1.2.137
  2. The new version removed libplist.sln, so add CMakeList.txt to build libplist.

libplist has no feature that need to test locally.

@PhoebeHui PhoebeHui added the info:internal This PR or Issue was filed by the vcpkg team. label Nov 7, 2019
@PhoebeHui PhoebeHui requested a review from JackBoosY November 7, 2019 08:24
@cenit
Copy link
Contributor

cenit commented Nov 9, 2019

Since the port was using an unofficial port in order to exploit the msvc solution it was offering, but now it’s gone, isn’t it better to switch to the official repository?
https://github.com/libimobiledevice/libplist

@PhoebeHui
Copy link
Contributor Author

PhoebeHui commented Nov 11, 2019

@cenit, thanks for helping review the changes!

https://github.com/libimobiledevice-win32/libplist contains some fixes for build issues on windows, these commits doesn't merge to libimobiledevice/libplist, I reported an issue libimobiledevice/libplist#147 to ask if they have a plan to merge these fixes. Instead of making several patches now.

@qmfrederik
Copy link
Contributor

qmfrederik commented Nov 11, 2019

Yeah, everything in libimobiledevice-win32/ is essentially a patchset to make libplist, libusbmuxd, libimobiledevice & friends compile correctly using MSVC.

I maintain that unofficial fork. I've opened a couple of PRs to upstream the changes; they have been open for few years by now.

The vcproj files moved to https://github.com/libimobiledevice-win32/libimobiledevice-vs if you're looking for those.

@PhoebeHui is your interest just libplist or do you want the full libimobiledevice stack?

@PhoebeHui
Copy link
Contributor Author

PhoebeHui commented Nov 12, 2019

@qmfrederik, thanks for the information!

#8842 already upgrade libideviceactivation, libimobiledevice and libusbmuxd, and build them with cmake, so vcproj files doesn't need any more.

So I think we're better to use libimobiledevice-win32/libplist now, and switch to libimobiledevice/libplist when the changes merged.

@grdowns grdowns self-assigned this Nov 18, 2019
@PhoebeHui
Copy link
Contributor Author

/azp run

@grdowns grdowns changed the title [libplist] Upgrade to 1.2.137 [libplist] Update to 1.2.137 Nov 19, 2019
@PhoebeHui PhoebeHui marked this pull request as ready for review November 20, 2019 01:51
@ras0219-msft
Copy link
Contributor

/azp run

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Dec 13, 2019
@dan-shaw
Copy link
Contributor

dan-shaw commented Jan 9, 2020

/azp run

@dan-shaw dan-shaw merged commit 3200392 into microsoft:master Jan 10, 2020
@PhoebeHui PhoebeHui deleted the dev/Phoebe/updatelibplist branch May 26, 2020 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants