Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libsrt]Add new port. #8712

Merged
merged 4 commits into from
Oct 28, 2019
Merged

[libsrt]Add new port. #8712

merged 4 commits into from
Oct 28, 2019

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Oct 24, 2019 •
edited
Loading

This port does not support uwp.

Related: #8705.

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Oct 24, 2019
@JackBoosY JackBoosY requested a review from PhoebeHui October 24, 2019 03:33
@JackBoosY JackBoosY marked this pull request as ready for review October 24, 2019 07:25
@maxsharabayko maxsharabayko mentioned this pull request Oct 24, 2019
Closed
PhoebeHui
PhoebeHui approved these changes Oct 25, 2019
View reviewed changes
@ras0219-msft
Copy link
Contributor

LGTM, thanks for the PR!

@ras0219-msft ras0219-msft merged commit d1d449e into microsoft:master Oct 28, 2019
@maxsharabayko
Copy link

Thank you for this PR!
Do you have a badge showing SRT is included in vcpkg? We can put to the SRT repository.

@JackBoosY JackBoosY deleted the dev/jack/8705 branch October 29, 2019 00:30
@JackBoosY
Copy link
Contributor Author

@maxlovic Well, we don't have badge now, or you can make a link to here?

@maxsharabayko
Copy link

@JackBoosY
The badge is more to track the version of SRT in vcpkg. Like what we have for Debian.
image

And of course to highlight to the user that he can use vcpkg to build SRT.

I can create one manually, but this would not be very convenient.
So just asked maybe you had something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees
No one assigned
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JackBoosY @ras0219-msft @maxsharabayko @PhoebeHui