Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbow3] Switch from unofficial repo to large patchset #8562

Merged
merged 1 commit into from
Nov 22, 2019
Merged

[dbow3] Switch from unofficial repo to large patchset #8562

merged 1 commit into from
Nov 22, 2019

Conversation

RamadanAhmed
Copy link
Contributor

@RamadanAhmed RamadanAhmed commented Oct 11, 2019

Fix #8547 portfile by using original repo and add .patch file with needed changes

@dan-shaw
Copy link
Contributor

Thanks for the PR! Usually, we want to make the patch file as minimal as possible and additional feature work should be submitted to the original repository.

See https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/maintainer-guide.md#minimize-patches

@cenit
Copy link
Contributor

cenit commented Oct 11, 2019

The portfile has already been accepted using his own personal repository which is even worse imho. At least having the patchset external, while very big, is better than the current situation.

@vicroms
Copy link
Member

vicroms commented Oct 16, 2019

The last merged PR to dbow3 is from March, and the author seems to have moved all of their effort to maintain fbow. But I'm OK with taking the patch file in the hope that the PR gets merged some day.

@JackBoosY
Copy link
Contributor

/azp run

@ras0219-msft ras0219-msft changed the title [dbow3] fix portfile [dbow3] Switch from unofficial repo to large patchset Nov 22, 2019
@ras0219-msft ras0219-msft merged commit cc29e68 into microsoft:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants