Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdl2-mixer]Re-fix dynamic call. #8335

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Conversation

JackBoosY
Copy link
Contributor

Define -D${PORT}="${PORT_LIBRARY}" to use dynamic call in sdl2-mixer.

Related: #8208.

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Sep 25, 2019
@JackBoosY
Copy link
Contributor Author

@Vermeille @lethal-guitar @timautry @Vultraz
Sorry for late. Can you test it?

Thanks.

@JackBoosY JackBoosY marked this pull request as ready for review September 25, 2019 10:20
@Vultraz
Copy link
Contributor

Vultraz commented Sep 25, 2019

It works for vorbis 👍

@Vermeille
Copy link

Can't look into it rn, gimme a few days. Sorry for the latency

@cbezault
Copy link
Contributor

It works for my couple of tests too. I'm going to merge this since the problem was pretty disruptive.

@cbezault cbezault merged commit 808a19c into microsoft:master Sep 25, 2019
@ghost
Copy link

ghost commented Sep 25, 2019

Works as advertised!!!!
Thanks for the quick turnaround, I appreciate it greatly. Have a wonderful week!!!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants