Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ignition-fuel-tools1] Add new port 🤖 #8136

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

traversaro
Copy link
Contributor

Add new port for the ignition-fuel-tools version 1, part of the Ignition Robotics Libraries (https://ignitionrobotics.org/).

Related PRs and issues:

cc @j-rivero

@traversaro
Copy link
Contributor Author

The arm64-windows build fails with the following message (similar to #7660):

-- Found CURL: optimized;C:/vsts/_work/1/s/installed/arm64-windows/lib/libcurl.lib;debug;C:/vsts/_work/1/s/installed/arm64-windows/debug/lib/libcurl-d.lib (found version "7.65.2-DEV")  
CMake Error at C:/vsts/_work/1/s/installed/arm64-windows/share/ignition-cmake0/cmake0/IgnImportTarget.cmake:172 (set_target_properties):
  Property INTERFACE_LINK_LIBRARIES may not contain link-type keyword
  "debug".  The INTERFACE_LINK_LIBRARIES property may contain
  configuration-sensitive generator-expressions which may be used to specify
  per-configuration rules.
Call Stack (most recent call first):
  C:/vsts/_work/1/s/installed/arm64-windows/share/ignition-cmake0/cmake0/IgnImportTarget.cmake:100 (_ign_sort_libraries)
  C:/vsts/_work/1/s/installed/arm64-windows/share/ignition-cmake0/cmake0/FindIgnCURL.cmake:52 (ign_import_target)
  C:/vsts/_work/1/s/scripts/buildsystems/vcpkg.cmake:256 (_find_package)
  C:/vsts/_work/1/s/installed/arm64-windows/share/ignition-cmake0/cmake0/IgnUtils.cmake:146 (find_package)
  CMakeLists.txt:31 (ign_find_package)


CMake Error at C:/vsts/_work/1/s/installed/arm64-windows/share/ignition-cmake0/cmake0/IgnImportTarget.cmake:106 (set_target_properties):
  Property INTERFACE_LINK_LIBRARIES may not contain link-type keyword
  "optimized".  The INTERFACE_LINK_LIBRARIES property may contain
  configuration-sensitive generator-expressions which may be used to specify
  per-configuration rules.
Call Stack (most recent call first):
  C:/vsts/_work/1/s/installed/arm64-windows/share/ignition-cmake0/cmake0/FindIgnCURL.cmake:52 (ign_import_target)
  C:/vsts/_work/1/s/scripts/buildsystems/vcpkg.cmake:256 (_find_package)
  C:/vsts/_work/1/s/installed/arm64-windows/share/ignition-cmake0/cmake0/IgnUtils.cmake:146 (find_package)
  CMakeLists.txt:31 (ign_find_package)


-- Looking for IgnCURL - found

@traversaro
Copy link
Contributor Author

The curl problem now propagated to other windows builds, probably something is being updated on curl and propagated to the builds. I will prepare a patch for ignition-cmake .

@traversaro traversaro force-pushed the addIgnitionFuelTools branch 2 times, most recently from faaface to 367850b Compare September 14, 2019 13:50
@traversaro
Copy link
Contributor Author

I fixed the CURL linking problem with a fix in ign-cmake0, that I also submitted upstream in https://bitbucket.org/ignitionrobotics/ign-cmake/pull-requests/175 .

@traversaro
Copy link
Contributor Author

The x64-windows-static failure is caused by two problems in the libyaml port:

  • For some reason, the yaml library names its library OFF.lib when compiled in x64-windows-static
  • The CMake config files for the yaml CMake package are installed in the share/libyaml library, so they are not found by CMake
    I think it makes more sense to fix these problems in separate PRs.

Add new port for the ignition-fuel-tools version 1, part
of the Ignition Robotics Libraries (https://ignitionrobotics.org/).
@traversaro
Copy link
Contributor Author

As soon as #8177 is merged, the x64-windows-static should work fine.

@vicroms
Copy link
Member

vicroms commented Sep 17, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@traversaro
Copy link
Contributor Author

traversaro commented Sep 24, 2019

@vicroms The tests on Azure Pipelines seems successful, feel free to let me know if there is anything else I can do, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants