[vcpkg] Continue on malformed paths in PATH #8129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbezault
suggested changes
Sep 11, 2019
JackBoosY
approved these changes
Sep 11, 2019
cbezault
changed the title
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
Previously vcpkg would exit on malformed paths. We now will continue and ignore the malformed path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #8116, when add ;; to PATH, it consider it’s a path and add quota to it( change to “;;” in PATH); In vcpkg, it use ; to split the PATH, so it will split “;;” to “ , empty , “ ,
So the base value becomes “\cmake.bat, it’s illegal path, and exit in this->exists(VCPKG_LINE_INFO, p).
In this case I think we shouldn’t exit when environment variable ‘PATH’ contains illegal path(eg ;;).