[unrar] Don't use a custom struct member alignment #8053
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason unrar's .vcxproj files specify a non-default member alignment, even though the source code already uses
pack
pragmas. With newer versions of the Windows SDK this actually breaks the build, as this build log snippet shows:I've added a patch for unrar that just deletes the
<StructMemberAlignment>
specifications from UnRARDll.vcxproj, which fixes the build.