[tcl] Add new port #8026
[tcl] Add new port #8026
Conversation
|
|
|
|
||
| file(INSTALL ${SOURCE_PATH}/license.terms DESTINATION ${CURRENT_PACKAGES_DIR}/share/tcl RENAME copyright) | ||
| else() | ||
| message(ERROR "Unsupported Operating System ${VCPKG_CMAKE_SYSTEM_NAME}") |
There was a problem hiding this comment.
While I appreciate you explicitly failing on platforms you didn't develop for, I know for a fact that TCL is cross-platform. Is the effort in getting it to work with linux and osx too high?
There was a problem hiding this comment.
@cbezault you are absolutely right! tcl has a custom config for linux https://github.com/tcltk/tcl/tree/master/unix and osx https://github.com/tcltk/tcl/tree/master/macosx.
unfortunately I didn't have much luck implementing on my Ubuntu VM, I believe the configuration needs a treatment similar to ffmpeg https://github.com/microsoft/vcpkg/tree/master/ports/ffmpeg , but was unable to apply this.
as far as osx goes I do not have a VM for that OS and so I cannot push a OS specific configuration with confidence. I can run it against the azure pipelines but that doesn't help me know if the package is usable after configuration.
There was a problem hiding this comment.
@cbezault I would also like to add that I do not know if ARM configuration is possible on Windows, see this line https://github.com/tcltk/tcl/blob/master/win/makefile.vc#L96
I know that ARM is definitely possible on Linux as I have seen builds for that configuration online
There was a problem hiding this comment.
Yeah last I remember I couldn't run Tcl on ARM. We'd have people emulate x86 on their arm devices if they really needed to run on them.
|
I'm inclined to merge this PR even if it's not perfect. Could you please sign the CLA? |
|
@greenbrettmichael ping. |
|
@cbezault I signed the CLA, sorry I didn't see your edit |
https://github.com/tcltk/tcl/tree/fb28af5fa6c4ffcd2d176c5617e5640acbfb8114 |
|
Good point the version string should be changed |
Support tcl core in vcpkg. related #7647