Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nativefiledialog] Add new port #7944

Merged
merged 4 commits into from
Sep 6, 2019
Merged

[nativefiledialog] Add new port #7944

merged 4 commits into from
Sep 6, 2019

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented Aug 28, 2019

@myd7349
Copy link
Contributor Author

myd7349 commented Sep 1, 2019 •
edited
Loading

Known issue:
Do not support UWP because the use of IFileDialog .

@myd7349 myd7349 marked this pull request as ready for review September 1, 2019 06:56
@grdowns
Copy link
Contributor

grdowns commented Sep 6, 2019

Thanks for the new port, @myd7349!

@grdowns grdowns merged commit 8e2f0c7 into microsoft:master Sep 6, 2019
@myd7349 myd7349 deleted the nativefiledialog-init branch September 6, 2019 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@grdowns grdowns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@myd7349 @grdowns