Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blosc] enable dependent ports to use debug builds #7649

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

tmpvar
Copy link
Contributor

@tmpvar tmpvar commented Aug 11, 2019

refs: #3601

The bulk of this work is to utilize the standard vcpkg find_package code to find the correct binaries in both Release and Debug modes.

When attempting to perform a debug build on an application that depends on openvdb the result was a run time failure. This is due to blosc not providing a mechanism to select its debug build and no way for it to find debug builds of its dependencies.

image

(you can ignore the issue with Half-2_3.dll as that is being worked on in #7636)

@tmpvar
Copy link
Contributor Author

tmpvar commented Aug 11, 2019

I don't see how this is failing .. perhaps this needs to be rebased on the openvdb changes in #7636 ( I did touch the FindBlosc.cmake over there)

@Rastaban
Copy link
Contributor

Usually this type of failure is due to the case-sensitive filesystem on the Linux VMs.

CMake Error at ports/blosc/portfile.cmake:56 (file):
  file COPY cannot find
  "/home/vcpkg/myagent/_work/4/s/ports/blosc/FindBlosc.cmake".
Call Stack (most recent call first):
  scripts/ports.cmake:74 (include)

Could you also bump the version in the CONTROL file to 1.17.0-1? It helps the vcpkg update command.

refs: microsoft#3601

The bulk of this work is to utilize the standard vcpkg find_package
code to find the correct binaries in both Release and Debug modes.
@tmpvar tmpvar force-pushed the tmpvar/blosc/fix-debug-builds branch from e5ec2a3 to 644caf1 Compare August 13, 2019 23:24
@tmpvar
Copy link
Contributor Author

tmpvar commented Aug 13, 2019

@Rastaban thanks for the tip - curious where you found that error.

I've bumped the control file as suggested and ended up renaming Findblosc.cmake to FindBlosc.cmake as that is the casing used throughout vcpkg https://github.com/microsoft/vcpkg/search?q=findblosc&unscoped_q=findblosc

@cbezault cbezault merged commit aa0c404 into microsoft:master Aug 14, 2019
@tmpvar tmpvar deleted the tmpvar/blosc/fix-debug-builds branch August 14, 2019 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants