Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Make CMakelists nicer 😁 #7638

Merged
merged 1 commit into from
Aug 17, 2019
Merged

[vcpkg] Make CMakelists nicer 😁 #7638

merged 1 commit into from
Aug 17, 2019

Conversation

strega-nil
Copy link
Contributor

@strega-nil strega-nil commented Aug 10, 2019 •
edited
Loading

Do a few things:

  • Add the "VCPKG_DEVELOPMENT_WARNINGS" flag
    • setting "WERROR" will also set this flag
    • This flag is set by default
    • on GCC, this will pass '-Wall -Wextra -Wpedantic -Werror'
    • on MSVC, this will pass '-W4 -WX'
  • On Visual Studio 2017 and later, pass '-permissive-'
  • Support Visual Studio 2015 in the CMakeLists.txt
  • Fix the fallout of these changes on the source code

@strega-nil strega-nil changed the title vcpkg] Compile under -Wall -Wextra -Wpedantic [vcpkg] Compile under -Wall -Wextra -Wpedantic Aug 10, 2019
@strega-nil strega-nil changed the title [vcpkg] Compile under -Wall -Wextra -Wpedantic [vcpkg] Make CMakelists nicer :D Aug 10, 2019
@strega-nil
Copy link
Contributor Author

Depends on #7637

@strega-nil strega-nil mentioned this pull request Aug 10, 2019
Closed
@strega-nil strega-nil changed the title [vcpkg] Make CMakelists nicer :D [vcpkg] Make CMakelists nicer 😁 Aug 12, 2019
@strega-nil strega-nil requested a review from Rastaban August 12, 2019 22:03
@strega-nil strega-nil marked this pull request as ready for review August 12, 2019 22:33
@strega-nil strega-nil requested a review from vicroms August 13, 2019 16:50
@strega-nil strega-nil self-assigned this Aug 13, 2019
@strega-nil
Copy link
Contributor Author

strega-nil commented Aug 13, 2019 •
edited
Loading

(Please don't merge! I want to write a better commit message after it's been accepted)

@vicroms vicroms mentioned this pull request Aug 13, 2019
Merged
@ras0219-msft ras0219-msft added the info:internal This PR or Issue was filed by the vcpkg team. label Aug 13, 2019
grdowns
grdowns reviewed Aug 16, 2019
View reviewed changes
@strega-nil
[vcpkg] Major tool CMakeLists.txt updates
d80ec29 
- Add the "VCPKG_DEVELOPMENT_WARNINGS" flag
	- setting "WERROR" will also set this flag
	- This flag is set by default
	- on GCC/clang, this will pass '-Wall -Wextra -Wpedantic -Werror'
	- on GCC, this will additionally pass '-Wmissing-declarations'
	- on clang, this will additionally pass '-Wmissing-prototypes'
	- on MSVC, this will pass '-W4 -WX'
- On Visual Studio 2017 and later, pass '-permissive-'
- Change the source for fallout of these changes
- add `format` subcommand
	- formats all C++ source and header files using clang-format
- move `include/vcpkg-test/catch.h` to `include/catch2/catch.hpp`
- pass CONFIGURE_DEPENDS to file(GLOB)
@strega-nil strega-nil merged commit 300e21d into microsoft:master Aug 17, 2019
@strega-nil strega-nil deleted the cmake-warnings branch August 17, 2019 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbezault cbezault cbezault left review comments

@Rastaban Rastaban Rastaban left review comments

@grdowns grdowns grdowns left review comments

@vicroms vicroms Awaiting requested review from vicroms

Assignees

@strega-nil strega-nil

@vicroms vicroms

Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@strega-nil @cbezault @vicroms @Rastaban @grdowns @ras0219-msft