[nsync] Add new port #7614

ehsan-mohammadi · 2019-08-09T10:47:28Z

Related to #7602. Needed for #7568.

Add new port nsync.

MVoz · 2019-08-09T10:57:20Z

in the previous port it was correct to delete empty folders
and add set(VCPKG_POLICY_EMPTY_PACKAGE enabled)

ehsan-mohammadi · 2019-08-09T11:00:37Z

in the previous port it was correct to delete empty folders
and add set(VCPKG_POLICY_EMPTY_PACKAGE enabled)

@voskrese So, should I add these lines before set(VCPKG_POLICY_EMPTY_PACKAGE enabled)?

file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug)
file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/lib)

MVoz · 2019-08-09T11:05:31Z

it seems like it doesn't make any difference in the port

before or after

ehsan-mohammadi · 2019-08-09T11:06:14Z

Ok, I'll add it.

MVoz · 2019-08-09T11:15:58Z

error x64-windows-static- dbg

CMake Error at cmake_install.cmake:36 (file):
  file INSTALL cannot find
  "C:/vsts/_work/1/s/buildtrees/nsync/x64-windows-static-dbg/nsync.lib".

add

~~file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/lib)~~

hmm....

MVoz · 2019-08-09T11:21:04Z

it seems easier to me through )))

file (COPY $ {SOURCE_PATH} / include

ehsan-mohammadi · 2019-08-09T11:23:34Z

@voskrese I added file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug). So, should I add file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/lib)?

MVoz · 2019-08-09T11:25:43Z

I hurried, then saw (REMOVE_RECURSE $ {CURRENT_PACKAGES_DIR} / debug)

ehsan-mohammadi · 2019-08-09T14:23:17Z

Finally, it works for all platforms. Thanks to @voskrese and @amiremohamadi.

dan-shaw

Thanks for working on the PR!

I have a few questions (in the review, as well): nsync doesn't appear to be installing include headers and libraries for Linux and Windows (non-static). Was this intended?

ports/nsync/portfile.cmake

ehsan-mohammadi · 2019-08-13T07:40:30Z

Thanks for working on the PR!

I have a few questions (in the review, as well): nsync doesn't appear to be installing include headers and libraries for Linux and Windows (non-static). Was this intended?

@dan-shaw Thanks for reviewing this PR. I think I need to help to make this PR better. This wasn't intended. So, do you have any suggestion?

ports/nsync/portfile.cmake

ehsan-mohammadi · 2019-08-15T20:34:21Z

We should vcpkg_install_cmake for all architectures. If we call vcpkg_build_cmake, vcpkg won't install libraries and include files.

@dan-shaw When I remove if else statement and use vcpkg_install_cmake for all architectures, checks failed for some of them.

ehsan-mohammadi · 2019-08-20T20:23:54Z

@ras0219-msft @cbezault @dan-shaw Finally, I think this PR can be merged into vcpkg. I'll be waiting for you.
Thanks!

ports/nsync/portfile.cmake

ports/nsync/CONTROL

ports/nsync/portfile.cmake

NancyLi1013 · 2020-01-14T07:47:48Z

/azp run

NancyLi1013 · 2020-01-20T03:08:45Z

I noticed that it failed on all Windows triplets except for x64-windows-static.
Are those expected?
Could you please take a look and try to fix the regressions?

ehsan-mohammadi · 2020-01-21T10:40:20Z

I noticed that it failed on all Windows triplets except for x64-windows-static.
Are those expected?
Could you please take a look and try to fix the regressions?

@NancyLi1013 I tried to install nsync on each non-static windows triplets. I found out this error occurs because of EXPAT_LINKAGE. I've got these errors:

atm_log.c.obj : error LNK2019: unresolved external symbol nsync_pthread_key_create referenced in function do_once
atm_log.c.obj : error LNK2019: unresolved external symbol nsync_pthread_getspecific referenced in function nsync_atm_log_
atm_log.c.obj : error LNK2019: unresolved external symbol nsync_pthread_setspecific referenced in function nsync_atm_log_
atm_log.c.obj : error LNK2019: unresolved external symbol nsync_init_callback_ referenced in function nsync_atm_log_
testing.c.obj : error LNK2019: unresolved external symbol nsync_mu_lock referenced in function testing_base_exit
testing.c.obj : error LNK2019: unresolved external symbol nsync_mu_unlock referenced in function testing_base_exit
testing.c.obj : error LNK2019: unresolved external symbol nsync_time_now referenced in function testing_stop_timer
time_extra.c.obj : error LNK2001: unresolved external symbol nsync_time_now
testing.c.obj : error LNK2019: unresolved external symbol nsync_time_sleep referenced in function testing_is_uniprocessor
time_extra.c.obj : error LNK2001: unresolved external symbol nsync_time_sleep
testing.c.obj : error LNK2019: unresolved external symbol nsync_time_add referenced in function testing_start_timer
testing.c.obj : error LNK2019: unresolved external symbol nsync_time_sub referenced in function testing_start_timer
time_extra.c.obj : error LNK2001: unresolved external symbol nsync_time_sub
testing.c.obj : error LNK2019: unresolved external symbol nsync_time_cmp referenced in function testing_stop_timer
time_extra.c.obj : error LNK2001: unresolved external symbol nsync_time_cmp
testing.c.obj : error LNK2019: unresolved external symbol nsync_time_ms referenced in function testing_is_uniprocessor
testing.c.obj : error LNK2019: unresolved external symbol nsync_mu_wait referenced in function testing_base_exit
testing.c.obj : error LNK2019: unresolved external symbol nsync_dll_init_ referenced in function testing_run_
testing.c.obj : error LNK2019: unresolved external symbol nsync_dll_remove_ referenced in function finish_run
testing.c.obj : error LNK2019: unresolved external symbol nsync_dll_make_last_in_list_ referenced in function testing_run_
testing.c.obj : error LNK2019: unresolved external symbol nsync_panic_ referenced in function testing_panic
testing.c.obj : error LNK2001: unresolved external symbol nsync_time_zero
time_extra.c.obj : error LNK2001: unresolved external symbol nsync_time_zero
time_extra.c.obj : error LNK2019: unresolved external symbol nsync_time_s_ns referenced in function nsync_time_from_dbl
nsync_test.dll : fatal error LNK1120: 19 unresolved externals

NancyLi1013 · 2020-01-22T03:06:24Z

/azp run

NancyLi1013 · 2020-01-22T09:58:43Z

@ehsan-mohammadi thanks for your feedback.
I will re run it and let's wait for the new test result.

NancyLi1013 · 2020-01-22T09:58:57Z

/azp run

NancyLi1013 · 2020-01-22T10:11:27Z

It seems that -DNSYNC_ENABLE_TESTS=OFF doesn't take effect.
The test part still was added to built.
Could you please check it again?

NancyLi1013 · 2020-03-05T06:15:00Z

Hi @ehsan-mohammadi
Could you please look int the regressions?

NancyLi1013 · 2020-04-16T06:00:58Z

@ehsan-mohammadi
Is work still being done for this PR?

NancyLi1013 · 2020-05-08T08:12:46Z

Closing this PR. Since it seems that no progress is being made. Please reopen if work is still being done.

Add port nsync

bca3183

Add REMOVE_RESCURSE

4cb2e81

ehsan-mohammadi added 2 commits August 9, 2019 18:26

Update portfile.cmake

f5353ca

Update portfile.cmake to install in all platforms

730b8d1

ehsan-mohammadi changed the title ~~Add port nsync~~ [nsync] Add new port Aug 9, 2019

dan-shaw self-assigned this Aug 9, 2019

dan-shaw reviewed Aug 12, 2019

View reviewed changes

ports/nsync/portfile.cmake Show resolved Hide resolved

ports/nsync/portfile.cmake Outdated Show resolved Hide resolved

dan-shaw reviewed Aug 15, 2019

View reviewed changes

ports/nsync/portfile.cmake Outdated Show resolved Hide resolved

Update portfile.cmake to resolve conversation

30d6c5f

ehsan-mohammadi added 4 commits August 20, 2019 23:44

Add CMakeLists.txt, Update portfile.cmake

a26c97e

Fix CMakeLists.txt

d4e73b0

Fix CMakeLists.txt for Windows platform

b7824a7

Update nsync library to 1.22.0

352e214

Add fix-install.patch

3e2b2e9

cbezault assigned grdowns and unassigned dan-shaw Aug 28, 2019

dan-shaw self-assigned this Sep 3, 2019

ras0219-msft reviewed Sep 7, 2019

View reviewed changes

ports/nsync/portfile.cmake Outdated Show resolved Hide resolved

grdowns added 2 commits September 7, 2019 16:48

Keep libs dirs; Remove debug include

9cb6f5b

Attempt fix of missing libs

e73f30b

PhoebeHui assigned NancyLi1013 Jan 14, 2020

NancyLi1013 suggested changes Jan 14, 2020

View reviewed changes

ports/nsync/CONTROL Outdated Show resolved Hide resolved

ports/nsync/portfile.cmake Outdated Show resolved Hide resolved

ports/nsync/portfile.cmake Outdated Show resolved Hide resolved

ehsan-mohammadi added 3 commits January 14, 2020 14:26

Add home page

dc3a9d7

Remove vcpkg_common_functions

94ae4ad

Change copyright install

1a003c6

ehsan-mohammadi requested a review from NancyLi1013 January 14, 2020 11:00

NancyLi1013 added the waiting for response label Jan 20, 2020

NancyLi1013 closed this May 8, 2020

NancyLi1013 unassigned grdowns May 8, 2020

luncliff mentioned this pull request Jan 17, 2021

[nsync] create a new port #15714

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[nsync] Add new port #7614

[nsync] Add new port #7614

ehsan-mohammadi commented Aug 9, 2019 •

edited

Loading

MVoz commented Aug 9, 2019

ehsan-mohammadi commented Aug 9, 2019 •

edited

Loading

MVoz commented Aug 9, 2019

ehsan-mohammadi commented Aug 9, 2019

MVoz commented Aug 9, 2019 •

edited

Loading

MVoz commented Aug 9, 2019

ehsan-mohammadi commented Aug 9, 2019

MVoz commented Aug 9, 2019

ehsan-mohammadi commented Aug 9, 2019

dan-shaw left a comment

ehsan-mohammadi commented Aug 13, 2019

ehsan-mohammadi commented Aug 15, 2019

ehsan-mohammadi commented Aug 20, 2019 •

edited

Loading

NancyLi1013 commented Jan 14, 2020

NancyLi1013 commented Jan 20, 2020

ehsan-mohammadi commented Jan 21, 2020 •

edited

Loading

NancyLi1013 commented Jan 22, 2020

NancyLi1013 commented Jan 22, 2020

NancyLi1013 commented Jan 22, 2020

NancyLi1013 commented Jan 22, 2020

NancyLi1013 commented Mar 5, 2020

NancyLi1013 commented Apr 16, 2020

NancyLi1013 commented May 8, 2020

[nsync] Add new port #7614

[nsync] Add new port #7614

Conversation

ehsan-mohammadi commented Aug 9, 2019 • edited Loading

MVoz commented Aug 9, 2019

ehsan-mohammadi commented Aug 9, 2019 • edited Loading

MVoz commented Aug 9, 2019

ehsan-mohammadi commented Aug 9, 2019

MVoz commented Aug 9, 2019 • edited Loading

MVoz commented Aug 9, 2019

ehsan-mohammadi commented Aug 9, 2019

MVoz commented Aug 9, 2019

ehsan-mohammadi commented Aug 9, 2019

dan-shaw left a comment

Choose a reason for hiding this comment

ehsan-mohammadi commented Aug 13, 2019

ehsan-mohammadi commented Aug 15, 2019

ehsan-mohammadi commented Aug 20, 2019 • edited Loading

NancyLi1013 commented Jan 14, 2020

NancyLi1013 commented Jan 20, 2020

ehsan-mohammadi commented Jan 21, 2020 • edited Loading

NancyLi1013 commented Jan 22, 2020

NancyLi1013 commented Jan 22, 2020

NancyLi1013 commented Jan 22, 2020

NancyLi1013 commented Jan 22, 2020

NancyLi1013 commented Mar 5, 2020

NancyLi1013 commented Apr 16, 2020

NancyLi1013 commented May 8, 2020

ehsan-mohammadi commented Aug 9, 2019 •

edited

Loading

ehsan-mohammadi commented Aug 9, 2019 •

edited

Loading

MVoz commented Aug 9, 2019 •

edited

Loading

ehsan-mohammadi commented Aug 20, 2019 •

edited

Loading

ehsan-mohammadi commented Jan 21, 2020 •

edited

Loading