Option to build using snappy.

[rotrida]

No description provided.

[msftclas]

All CLA requirements met.

[rotrida]

Adding Snappy compression option.

[LilyWangL]

Related issue: #7454

[myd7349]

snappy is not necessary here, since librdkafka has a bundled version of snappy-c: https://github.com/edenhill/librdkafka/blob/master/src/snappy.c

[myd7349]

Hi! @rotrida Sorry for not solving your problem before, as I thought librdkafka is always built with snappy:
https://github.com/edenhill/librdkafka/blob/d443b4f025058172d2c8568376e36e54aba0b8b4/src/win32_config.h#L38
https://github.com/edenhill/librdkafka/blob/master/packaging/cmake/config.h.in#L34

As we can see, librdkafka has two configuration header files:
One named config.h.in, which is supposed to be used when configuring with CMake.
The other one, win32_config.h, is supposed to be used together with the VS solution provided by librdkafka.
Unfortunately, in rd.h:
https://github.com/edenhill/librdkafka/blob/master/src/rd.h#L54-L60
That is, win32_config.h is always used when building with MSVC, even you configure librdkafka with CMake.
And in win32_config.h:

#ifndef WITHOUT_WIN32_CONFIG
#define WITH_SSL 1
#define WITH_ZLIB 1
#define WITH_SNAPPY 1
#define WITH_ZSTD 1
/* zstd is linked dynamically on Windows, but the dynamic library provides
 * the experimental/advanced API, just as the static builds on *nix */
#define WITH_ZSTD_STATIC 1
#define WITH_SASL_SCRAM 1
#define WITH_SASL_OAUTHBEARER 1
#define ENABLE_DEVEL 0
#define WITH_PLUGINS 1
#define WITH_HDRHISTOGRAM 1
#endif

WITHOUT_WIN32_CONFIG is defined here, which has a default value 'ON':
https://github.com/edenhill/librdkafka/blob/d443b4f025058172d2c8568376e36e54aba0b8b4/CMakeLists.txt#L167

[myd7349]

I guess this patch should fix the snappy support:

diff --git a/ports/librdkafka/portfile.cmake b/ports/librdkafka/portfile.cmake
index 5bc66fdf..88bcf5e3 100644
--- a/ports/librdkafka/portfile.cmake
+++ b/ports/librdkafka/portfile.cmake
@@ -27,6 +27,7 @@ vcpkg_configure_cmake(
         -DRDKAFKA_BUILD_EXAMPLES=OFF
         -DRDKAFKA_BUILD_TESTS=OFF
         -DWITH_BUNDLED_SSL=OFF
+        -DWITHOUT_WIN32_CONFIG=OFF
         ${FEATURE_OPTIONS}
     OPTIONS_DEBUG
         -DENABLE_DEVEL=ON

[myd7349]

I have created a PR in the upstream before: confluentinc/librdkafka#2323

[rotrida]

I have created a PR in the upstream before: edenhill/librdkafka#2323

Great! Thank you for getting into it.

[myd7349]

Hi! @rotrida Please do not close your PR yet. Instead please update your PR like this:

vcpkg_configure_cmake(
    SOURCE_PATH ${SOURCE_PATH}
    PREFER_NINJA
    OPTIONS
        -DRDKAFKA_BUILD_STATIC=${RDKAFKA_BUILD_STATIC}
        -DRDKAFKA_BUILD_EXAMPLES=OFF
        -DRDKAFKA_BUILD_TESTS=OFF
        -DWITH_BUNDLED_SSL=OFF
        -DWITHOUT_WIN32_CONFIG=OFF # ADD THIS OPTION HERE
        ${FEATURE_OPTIONS}
    OPTIONS_DEBUG
        -DENABLE_DEVEL=ON
        -DENABLE_REFCNT_DEBUG=ON
        -DENABLE_SHAREDPTR_DEBUG=ON
        -DWITHOUT_OPTIMIZATION=ON
    OPTIONS_RELEASE
        -DENABLE_DEVEL=OFF
        -DENABLE_REFCNT_DEBUG=OFF
        -DENABLE_SHAREDPTR_DEBUG=OFF
        -DWITHOUT_OPTIMIZATION=OFF
)

and bump the version number in the CONTROL file.

[myd7349]

Hi! @rotrida Thanks! This way this issue can get a quick fix in vcpkg and maybe other guys can benefit from this PR too.

[myd7349]

Superseded by #7469 . So close this one.

[rotrida]

Hi @myd7349 ,

Unfortunatelly removal, adding "-DWITHOUT_WIN32_CONFIG=OFF" didn't worked as expected. We can see at #7469. Do you have any other idea?

Thanks,

Rodrigo.