[curl] Update to 7.66.0

[past-due]

Also updates the USAGE instructions to:

• use CONFIG mode (to pick up the CMake exported configuration)
• link to the CURL::libcurl target (which picks up the proper dependencies / link information from the CMake exported configuration)

[cenit]

Also updates the USAGE instructions to:

Just asking: isn't it better in this case to remove the usage file and let vcpkg deal with it automatically? If it finds an exported config, it should print how to use it

[past-due]

@Rastaban, @vicroms: CI passing (after rebase)

[cbezault]

The reason why you're changing the usage is to point users to the targets exported by curl's config? Sure that's fair, though most projects rely on CMake's module. If that's the goal (which I think it is) you should just let vcpkg auto-generate the message.

[past-due]

Ah yes, to clarify:

• To properly link to vcpkg's curl port in all circumstances, it is necessary to explicitly specify CONFIG mode and link to the CURL::libcurl exported target.

find_package(CURL CONFIG REQUIRED)
target_link_libraries(main PRIVATE CURL::libcurl)

Using CMake's module will fail to pick up proper dependencies (causing linker errors) depending on the configuration used for the curl port.

References:
#7332 (comment)
#7260 (comment)

[cenit]

Isn’t better in this case to prepare a wrapper to force the config whatever the user requested and to export all targets created by the official CMake module? Otherwise many projects that use traditional settings would have to adapt with a specific case for vcpkg

[cbezault]

@past-due, to be clear we're not going to merge this until you implement @cenit's suggestion.

[past-due]

@cbezault: Documentation on wrappers seems lacking? I've committed a rough draft, but have not had a chance to test it. (And likely won't have time this month.) Feel free to push any changes that are required.

(For example: Is it necessary to check for CONFIG IN_LIST ARGS before appending CONFIG? Does the vcpkg-cmake-wrapper.cmake need to be installed - and where?)

And again, just to clarify, the current status of the curl port is that the USAGE recommendation is broken / incorrect.

[kevinlul]

curl 7.66.0 has been released.

[cbezault]

Thanks for the work so far. Yes you do need to install the wrapper. I'll work on getting this merged.

[cbezault]

/azp run

[cenit]

is it really necessary? looks unnecessarily complicated.
I'd take a look at what I did for LibLZMA, also because there is the "MODULE" keyword forgotten (which is incompatible with the CONFIG keyword but not managed here...)

https://github.com/microsoft/vcpkg/blob/master/ports/liblzma/vcpkg-cmake-wrapper.cmake

[cbezault]

hmmm, is list(REMOVE_ITEM) case-insensitive? It does look cleaner.

[cenit]

can you really pass MODULE, CONFIG and NO_MODULE lowercase? TWIL

[cbezault]

Huh, apparently it's inconsistently implemented but they are supposed to be case-sensitive. TIL. I'll move to your approach.

[cenit]

in this PR curlpp CONTROL file was not bumped and people that upgraded (like me) are now in a broken state, since curlpp target is not fine with latest curl changes

it is therefore necessary to delete curlpp and reinstall, or just prepare a PR to bump its version (without any other modification)