Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libevent] Upgrade to version 2.1.10 #6969

Merged
merged 5 commits into from
Jun 25, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ports/fizz/fix-build_error.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/fizz/CMakeLists.txt b/fizz/CMakeLists.txt
index 7f8769a..debac4e 100644
--- a/fizz/CMakeLists.txt
+++ b/fizz/CMakeLists.txt
@@ -81,7 +81,7 @@ if(TARGET event)
message(STATUS "Found libevent from package config")
list(APPEND FIZZ_SHINY_DEPENDENCIES event)
else()
- find_package(Libevent MODULE REQUIRED)
+ find_package(Libevent CONFIG REQUIRED)
list(APPEND FIZZ_LINK_LIBRARIES ${LIBEVENT_LIB})
list(APPEND FIZZ_INCLUDE_DIRECTORIES ${LIBEVENT_INCLUDE_DIR})
endif()
8 changes: 5 additions & 3 deletions ports/fizz/portfile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@ vcpkg_check_linkage(ONLY_STATIC_LIBRARY)
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO facebookincubator/fizz
REF 6d26a1be8d7a20d8d89c374ee3dc5c452d18c18d
REF 6d26a1be8d7a20d8d89c374ee3dc5c452d18c18d
SHA512 bc6aa17a97fdfc53d0a247b876cbd1fea8214608b7e463dcf21e34df65015fe77e617c5a6c6bfa84b87e60e56b6aeb89aa2d8d774f97fc1f76f415869948a48a
HEAD_REF master
PATCHES find-zlib.patch
PATCHES
find-zlib.patch
fix-build_error.patch
)

# Prefer installed config files
Expand All @@ -28,7 +30,7 @@ vcpkg_configure_cmake(
)

vcpkg_install_cmake()
vcpkg_fixup_cmake_targets(CONFIG_PATH "lib/cmake/fizz")
vcpkg_fixup_cmake_targets(CONFIG_PATH lib/cmake/fizz)
vcpkg_copy_pdbs()

file(READ ${CURRENT_PACKAGES_DIR}/share/fizz/fizz-config.cmake _contents)
Expand Down
2 changes: 1 addition & 1 deletion ports/libevent/CONTROL
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Source: libevent
Version: 2.1.8-5
Version: 2.1.10
Build-Depends: openssl
Homepage: https://github.com/libevent/libevent
Description: An event notification library
36 changes: 36 additions & 0 deletions ports/libevent/fix-arm_build.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 44b6e18..19c024f 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -322,7 +322,7 @@ endif()
# Winsock.
if(WIN32)
set(CMAKE_EXTRA_INCLUDE_FILES winsock2.h ws2tcpip.h)
- set(CMAKE_REQUIRED_LIBRARIES ws2_32.lib)
+ set(CMAKE_REQUIRED_LIBRARIES ws2_32.lib advapi32.lib shell32.lib)
set(CMAKE_REQUIRED_DEFINITIONS -FIwinsock2.h -FIws2tcpip.h)
endif()
if (SOLARIS)
diff --git a/cmake/AddEventLibrary.cmake b/cmake/AddEventLibrary.cmake
index 411ca9d..869735e 100644
--- a/cmake/AddEventLibrary.cmake
+++ b/cmake/AddEventLibrary.cmake
@@ -73,6 +73,8 @@ macro(add_event_library LIB_NAME)
list(APPEND ADD_EVENT_LIBRARY_TARGETS "${LIB_NAME}_static")

set(ADD_EVENT_LIBRARY_INTERFACE "${LIB_NAME}_static")
+
+ target_link_libraries("${LIB_NAME}_static" PRIVATE ${CMAKE_REQUIRED_LIBRARIES})
endif()

if (${EVENT_LIBRARY_SHARED})
@@ -81,7 +83,8 @@ macro(add_event_library LIB_NAME)
target_link_libraries("${LIB_NAME}_shared"
${CMAKE_THREAD_LIBS_INIT}
${LIB_PLATFORM}
- ${LIB_LIBRARIES})
+ ${LIB_LIBRARIES}
+ ${CMAKE_REQUIRED_LIBRARIES})

if (EVENT_SHARED_FLAGS)
set_event_shared_lib_flags("${LIB_NAME}" "${EVENT_SHARED_FLAGS}")
26 changes: 26 additions & 0 deletions ports/libevent/fix-file_path.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 6e91c08..44b6e18 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1430,7 +1430,7 @@ configure_file(${PROJECT_SOURCE_DIR}/cmake/LibeventConfigBuildTree.cmake.in
# Calculate the relative directory from the Cmake dir.
file(RELATIVE_PATH
REL_INCLUDE_DIR
- "${EVENT_INSTALL_CMAKE_DIR}"
+ "${CURRENT_PACKAGES_DIR}/${EVENT_INSTALL_CMAKE_DIR}"
"${CMAKE_INSTALL_PREFIX}/include")

# Note the LIBEVENT_CMAKE_DIR is defined in LibeventConfig.cmake.in,
diff --git a/cmake/AddEventLibrary.cmake b/cmake/AddEventLibrary.cmake
index 9de4484..411ca9d 100644
--- a/cmake/AddEventLibrary.cmake
+++ b/cmake/AddEventLibrary.cmake
@@ -113,7 +113,7 @@ macro(add_event_library LIB_NAME)
EXPORT LibeventTargets
LIBRARY DESTINATION "lib" COMPONENT lib
ARCHIVE DESTINATION "lib" COMPONENT lib
- RUNTIME DESTINATION "lib" COMPONENT lib
+ RUNTIME DESTINATION "bin" COMPONENT bin
PUBLIC_HEADER DESTINATION "include/event2"
COMPONENT dev
)
36 changes: 0 additions & 36 deletions ports/libevent/fix-target-files.patch

This file was deleted.

23 changes: 19 additions & 4 deletions ports/libevent/portfile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,25 @@ endif()
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO libevent/libevent
REF release-2.1.8-stable
SHA512 0d5c872dc797b69ab8ea4b83aebcbac20735b8c6f5adfcc2950aa4d6013d240f5fac3376e817da75ae0ccead50cec0d931619e135a050add438777457b086549
REF release-2.1.10-stable
SHA512 8c336df258f7a12164da739b0ea68bebcc8b2ea4f4a839300aa1c5edfb673ac5d6517f882ba04ab35d406489ddd682a319e39fa6784ac0cab73227d42e503a55
PATCHES
"fix-target-files.patch"
fix-file_path.patch
fix-arm_build.patch
)

if (VCPKG_LIBRARY_LINKAGE STREQUAL "dynamic")
set(LIBEVENT_LIB_TYPE SHARED)
else()
set(LIBEVENT_LIB_TYPE STATIC)
endif()

vcpkg_configure_cmake(
SOURCE_PATH ${SOURCE_PATH}
PREFER_NINJA
OPTIONS
-DEVENT_INSTALL_CMAKE_DIR:PATH=share/libevent
-DEVENT__LIBRARY_TYPE=${LIBEVENT_LIB_TYPE}
-DEVENT__DISABLE_BENCHMARK=ON
-DEVENT__DISABLE_TESTS=ON
-DEVENT__DISABLE_REGRESS=ON
Expand All @@ -28,7 +36,14 @@ vcpkg_install_cmake()

file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/include)

vcpkg_fixup_cmake_targets()
if (NOT VCPKG_CMAKE_SYSTEM_NAME OR VCPKG_CMAKE_SYSTEM_NAME STREQUAL "windows" OR VCPKG_CMAKE_SYSTEM_NAME STREQUAL "WindowsStore")
vcpkg_fixup_cmake_targets(CONFIG_PATH cmake TARGET_PATH share/libevent)
elseif (VCPKG_CMAKE_SYSTEM_NAME STREQUAL "Linux")
vcpkg_fixup_cmake_targets(CONFIG_PATH lib/cmake TARGET_PATH share)
elseif (VCPKG_CMAKE_SYSTEM_NAME STREQUAL "Darwin")
vcpkg_fixup_cmake_targets(CONFIG_PATH lib/cmake TARGET_PATH share)
endif()

vcpkg_copy_pdbs()

file(COPY ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/libevent)
Expand Down