-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: [libzippp] New port: C++ wrapper for libzip #6801
Conversation
@ctabin are you interested in the vcpkg port? The windows-static port fails and Linux / OSX are still missing |
Hello @PhilLab, Yes that would be great ! |
@ctabin: Could help with the static port? I don't quite understand why it fails |
@PhilLab I'll take a look asap 😅 |
Hi @PhilLab Thanks for the enthusiasm in adding new ports! I made some (pretty invasive) changes to your PR. I replaced the build system (CMakeLists.txt file), to address some issues (@ctabin can you review whether these changes are wanted, so I might consider submitting a PR to
|
@vicroms: Thank you for extending the PR. As my current Cmake knowledge is limited to "making stuff work somehow" it is good to see a clearer approach 😄 |
Hello @vicroms, Thanks for investigating and solving the static builds ! 😃 Your changes looks good to me and it would be awesome if you could submit a PR, so I would to a new release of libzippp with the latest changes. |
@vicroms The port files now do not copy the pdb files anymore, is this intended? |
@vicroms Additionally as I noticed now, the dependent
fails because Libzip could not be found:
|
@PhilLab Unfortunately LibZip does not provide CMake support for the installed targets. I'm working on ctabin/libzippp#52 to install the FindLIBZIP.cmake (which fixes that) together with some other changes. You might want to watch that PR and update the vcpkg once merged |
Closes #6600
Please review thoroughly as this was more or less trial-and-error :-D