Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[assimp] Update to 5.3.1, fix pkg-config #33957

Merged
merged 7 commits into from
Sep 29, 2023
Merged

[assimp] Update to 5.3.1, fix pkg-config #33957

merged 7 commits into from
Sep 29, 2023

Conversation

Osyotr
Copy link
Contributor

@Osyotr Osyotr commented Sep 24, 2023 •
edited
Loading

https://github.com/assimp/assimp/releases/tag/v5.3.1
assimp/assimp@v5.2.5...v5.3.1

Note:
assimp/assimp#788 is finally resolved, allowing us to remove vendored polyclipping

Fixes #34061

@Osyotr Osyotr marked this pull request as draft September 24, 2023 17:25
@Cheney-W Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label Sep 25, 2023
@Cheney-W
Copy link
Contributor 

qt5-3d:x64-windows-static
qt5-3d:x64-windows-static-md
qt5-3d:x64-linux
qt5-3d:x64-osx

Failed with below error:
ERROR: Feature 'system-assimp' was enabled, but the pre-condition 'features.assimp && libs.assimp' failed.

Error logs: https://dev.azure.com/vcpkg/public/_build/results?buildId=94455&view=artifacts&pathAsName=false&type=publishedArtifacts

@Cheney-W
Copy link
Contributor 

REGRESSION: pmdk:x64-linux is marked as fail but not supported for x64-linux.
REGRESSION: gtk:x64-windows-static is marked as fail but one dependency is not supported for x64-windows-static.

Above issues will be solved by PR #33999

@Osyotr Osyotr marked this pull request as ready for review September 26, 2023 18:04
Cheney-W
Cheney-W previously approved these changes Sep 27, 2023
View reviewed changes
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Sep 27, 2023
@MonicaLiu0311
Copy link
Contributor

There is a request #34061 to update to 5.3.1. Are you willing to update to the latest version directly?

@Osyotr Osyotr changed the title [assimp] Update to 5.3.0 [assimp] Update to 5.3.1 Sep 28, 2023
@Osyotr Osyotr changed the title [assimp] Update to 5.3.1 [assimp] Update to 5.3.1, fix pkg-config Sep 28, 2023
@vicroms vicroms merged commit 5eea628 into microsoft:master Sep 29, 2023
@Osyotr Osyotr deleted the assimp branch September 29, 2023 06:51
clementperon pushed a commit to clementperon/vcpkg that referenced this pull request Oct 16, 2023
@Osyotr @clementperon
[assimp] Update to 5.3.1, fix pkg-config (microsoft#33957)
1675c1d 
* [assimp] Update to 5.3.0

* Remove <utf8.h> from public include

* [assimp] fix pkg-config for static builds

* [qt5-3d] Use pkgconfig to find assimp

* [assimp] -llibassimp -> -lassimp

* [assimp] Update to 5.3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cheney-W Cheney-W Cheney-W left review comments

Assignees

@Cheney-W Cheney-W

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[assimp] update to 5.3.1
4 participants
@Osyotr @Cheney-W @MonicaLiu0311 @vicroms