Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[icu] Fix #30532: trying to set rpath on missing libicutu #30544

Merged
merged 4 commits into from
Apr 12, 2023
Merged

[icu] Fix #30532: trying to set rpath on missing libicutu #30544

merged 4 commits into from
Apr 12, 2023

Conversation

janisozaur
Copy link
Contributor

@janisozaur janisozaur commented Mar 30, 2023 •
edited
Loading

#29196 introduced new feature flag [tools] which prevents generation of libicutu. The PR in question did not take into account dynamic linkage target where rpath is set to hardcoded and no longer valid list of libraries.

This PR dynamically detects presence of [tools] feature and adds libicutu for rpath fix as necessary.

Fixes #30532

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@janisozaur janisozaur mentioned this pull request Mar 30, 2023
Closed
@MonicaLiu0311 MonicaLiu0311 self-assigned this Mar 30, 2023
@MonicaLiu0311 MonicaLiu0311 added the category:port-bug The issue is with a library, which is something the port should already support label Mar 30, 2023
@janisozaur
[icu] Fix microsoft#30532: trying to set rpath on missing libicutu
ac80fda 
microsoft#29196 introduced new feature flag `[tools]` which
prevents generation of `libicutu`. The PR in question did not take into
account dynamic linkage target where rpath is set to hardcoded and no
longer valid list of libraries.

This PR dynamically detects presence of `[tools]` feature and adds
`libicutu` for rpath fix as necessary.
@janisozaur janisozaur force-pushed the icu-dynamic-no-libicutu branch from b009cff to ac80fda Compare March 30, 2023 10:12
@MonicaLiu0311
Copy link
Contributor

Depends on #30546

@MonicaLiu0311 MonicaLiu0311 added the depends:different-pr This PR or Issue depends on a PR which has been filed label Mar 31, 2023
@janisozaur
Copy link
Contributor Author

I plan to do a release that would benefit from this PR, can I expect this to be merged today? I can see #30456 which you mentioned is already approved and has all the checks green

@MonicaLiu0311 MonicaLiu0311 removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Apr 3, 2023
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Apr 12, 2023
@MonicaLiu0311
Copy link
Contributor

Feature tools is tested successfully in the following triplet:
x64-windows

@BillyONeal BillyONeal merged commit 4f9d25a into microsoft:master Apr 12, 2023
@BillyONeal
Copy link
Member

Thanks!

This was referenced Apr 20, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonicaLiu0311 MonicaLiu0311 MonicaLiu0311 approved these changes

Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[icu] Build error on arm64 macos
3 participants
@janisozaur @MonicaLiu0311 @BillyONeal