Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tab selection to bring the tab into view #8832

Merged
1 commit merged into from
Jan 20, 2021
Merged

Fix tab selection to bring the tab into view #8832

1 commit merged into from
Jan 20, 2021

Conversation

Don-Vito
Copy link
Contributor

PR Checklist

##Detailed Description of the Pull Request / Additional comments
A workaround for microsoft/microsoft-ui-xaml#3945.
Thanks to @michael-hawker and @chingucoding for the suggested solution.

@ghost ghost added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Jan 20, 2021
@Don-Vito
Copy link
Contributor Author

BringIntoView

@marcelwgn
Copy link
Contributor

It might be worth adding a tracking issue to remove this workaround as the PR on the WinUI side is already open and with a later version, this workaround wouldn't be necessary anymore.

@Don-Vito Don-Vito mentioned this pull request Jan 20, 2021
Open
@Don-Vito
Copy link
Contributor Author

Don-Vito commented Jan 20, 2021 •
edited
Loading

It might be worth adding a tracking issue to remove this workaround as the PR on the WinUI side is already open and with a later version, this workaround wouldn't be necessary anymore.

Makes sense! The issue is here: #8833. Thanks again!

zadjii-msft
zadjii-msft approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

God it's so simple I love it.

@zadjii-msft zadjii-msft added AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off labels Jan 20, 2021
@ghost
Copy link

ghost commented Jan 20, 2021

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 3 hours 33 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@marcelwgn
Copy link
Contributor

Makes sense! The issue is here: #8833. Thanks again!

Awesome, thanks!

@ghost ghost merged commit 12b12d5 into microsoft:main Jan 20, 2021
DHowett pushed a commit that referenced this pull request Jan 25, 2021
@Don-Vito @DHowett
Fix tab selection to bring the tab into view (#8832)
bda1494 
## PR Checklist
* [x] Closes #3638
* [x] CLA signed.
* [ ] Tests added/passed
* [ ] Documentation updated.
* [ ] Schema updated.
* [x] I've discussed this with core contributors already.

##Detailed Description of the Pull Request / Additional comments
A workaround for microsoft/microsoft-ui-xaml#3945.
Thanks to @michael-hawker and @chingucoding for the suggested solution.

(cherry picked from commit 12b12d5)
@ghost
Copy link

ghost commented Jan 28, 2021

🎉Windows Terminal v1.5.10271.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jan 28, 2021
Closed
@ghost
Copy link

ghost commented Jan 28, 2021

🎉Windows Terminal Preview v1.6.10272.0 has been released which incorporates this pull request.:tada:

Handy links:

mpela81 pushed a commit to mpela81/terminal that referenced this pull request Jan 28, 2021
@Don-Vito @mpela81
Fix tab selection to bring the tab into view (microsoft#8832)
149c948 
## PR Checklist
* [x] Closes microsoft#3638
* [x] CLA signed.
* [ ] Tests added/passed
* [ ] Documentation updated.
* [ ] Schema updated.
* [x] I've discussed this with core contributors already.

##Detailed Description of the Pull Request / Additional comments
A workaround for microsoft/microsoft-ui-xaml#3945.
Thanks to @michael-hawker and @chingucoding for the suggested solution.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@marcelwgn marcelwgn marcelwgn approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@michael-hawker michael-hawker michael-hawker approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@DHowett DHowett Awaiting requested review from DHowett

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Don-Vito @marcelwgn @carlos-zamora @zadjii-msft @michael-hawker