Fix the xterm and SGR mouse encodings for CTRL, ALT, SHIFT #8379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also fixes an observed issue in Windows Terminal where we were passing in a console-style modifiers enum when MouseInput is expecting MK_ constants. I decided to unify MouseInput around the console-style modifier constants because they have support for META (which MK_ does not) and can differentiate between left/right alt/ctrl. Our tests are fundamentally flawed here: they use a copy of the modifier key generating logic _themselves_, so we got a bit of "error carried forward." I did not fix the tests to use known-good control sequences, I simply replaced the character generator with another copy of the modifier code. I did, however, extend them to test ctrl|meta and left/right modifiers. Fixes #8291
ghost
added
Area-VT
DHowett
changed the title
carlos-zamora
approved these changes
Nov 23, 2020
|
@msftbot make sure @zadjii-msft signs off |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
zadjii-msft
approved these changes
Nov 30, 2020
ghost
merged commit
DHowett
added a commit
that referenced
this pull request
Jan 13, 2021
N * Change backslashes in include statements to forward slashes (CC-8205) Dustin L. Howett * Refactor DEC/ANSI modes to avoid duplication when we add SM/RM (GH-8469) * Fix the xterm and SGR mouse encodings for CTRL, ALT, SHIFT (GH-8379) James Holderness * Fix rendering of DBCS characters when partially off screen (CC-8438) * Correct horizontal coordinates in viewport overflow test (CC-8456) * Correct paths in the the runut and runft test scripts (CC-8488) * Retain horizontal viewport offset when moving to bottom (CC-8434) * Fix out-of-bounds exceptions in Set...{Buffer,Screen}Size (CC-8309) PankajBhojwani (1) * Implement ConEmu's OSC 9;4 to set the taskbar progress indicator (CC-8055) Chester Liu (1) * Improve OSC 8 Hyperlink parsing logic (CC-7962) Related work items: #31090459, #31090805, #31090808, #31090810
DHowett
added a commit
that referenced
this pull request
Jan 25, 2021
We had the xterm and SGR codings for meta/ctrl backwards. Oops. This commit also fixes an observed issue in Windows Terminal where we were passing in a console-style modifiers enum when MouseInput is expecting MK_ constants. I decided to unify MouseInput around the console-style modifier constants because they have support for META (which MK_ does not) and can differentiate between left/right alt/ctrl. Our tests are fundamentally flawed here: they use a copy of the modifier key generating logic _themselves_, so we got a bit of "error carried forward." I did not fix the tests to use known-good control sequences, I simply replaced the character generator with another copy of the modifier code. I did, however, extend them to test ctrl|meta and left/right modifiers. Fixes #8291 (cherry picked from commit b1e1c7c)
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had the xterm and SGR codings for meta/ctrl backwards. Oops.
This commit also fixes an observed issue in Windows Terminal where we
were passing in a console-style modifiers enum when MouseInput is
expecting MK_ constants.
I decided to unify MouseInput around the console-style modifier
constants because they have support for META (which MK_ does not) and
can differentiate between left/right alt/ctrl.
Our tests are fundamentally flawed here: they use a copy of the
modifier key generating logic themselves, so we got a bit of "error
carried forward."
I did not fix the tests to use known-good control sequences, I simply
replaced the character generator with another copy of the modifier code.
I did, however, extend them to test ctrl|meta and left/right modifiers.
Fixes #8291