Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove location-specific suffixes from the zh- lang specifiers #13148

Merged
1 commit merged into from
May 24, 2022
Merged

Remove location-specific suffixes from the zh- lang specifiers #13148

1 commit merged into from
May 24, 2022

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented May 23, 2022

This only impacts the UI. We can take a workitem to rename the loc data
later. When the user specifies zh-Hans/zh-Hant, the resource mapper does
the right thing.

Related to #8984

@DHowett
Remove location-specific suffixed from the zh- lang specifiers
f2c2c93 
This only impacts the UI. We can take a workitem to rename the loc data
later. When the user specifies zh-Hans/zh-Hant, the resource mapper does
the right thing.
@DHowett
Copy link
Member Author

DHowett commented May 23, 2022

Before:

image

After:

image

@DHowett DHowett changed the title Remove location-specific suffixed from the zh- lang specifiers Remove location-specific suffixes from the zh- lang specifiers May 23, 2022
zadjii-msft
zadjii-msft approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QQ: will changing these strings break existing folks who changed their language already? For ex:

    "language": "zh-Hant-TW",

Changing that today to "language": "zh-Hant" in the json seems to load traditional (good), but the UI does display an empty language:

image

We cool with that?

@DHowett
Copy link
Member Author

DHowett commented May 23, 2022

I'm cool with that.

@DHowett
Copy link
Member Author

DHowett commented May 23, 2022

@msftbot merge this in 1 minute

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label May 23, 2022
@ghost
Copy link

ghost commented May 23, 2022

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Mon, 23 May 2022 22:07:30 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@DHowett
Copy link
Member Author

DHowett commented May 24, 2022

Haha I built the final build without this. Oh well!

@zadjii-msft zadjii-msft linked an issue May 24, 2022 that may be closed by this pull request
关于微软应用商店语言简洁的一个非常重要的建议，请将【中文（台湾）】改为【中文（繁体）】，谢谢！ #8984
Closed
@ghost ghost merged commit 78852e0 into main May 24, 2022
@ghost ghost deleted the dev/duhowett/geopol branch May 24, 2022 16:58
DHowett added a commit that referenced this pull request May 25, 2022
@DHowett
Remove location-specific suffixes from the zh- lang specifiers (#13148)
07f7717 
This only impacts the UI. We can take a workitem to rename the loc data
later. When the user specifies zh-Hans/zh-Hant, the resource mapper does
the right thing.

Related to #8984

(cherry picked from commit 78852e0)
Service-Card-Id: 82315897
Service-Version: 1.14
@ghost
Copy link

ghost commented Jun 10, 2022

🎉Windows Terminal Preview v1.14.145 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhecker lhecker lhecker approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Milestone
No milestone
3 participants
@DHowett @lhecker @zadjii-msft