Protect the command palette against being paged with no items #12528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two crashes amounting to 14% of our crash burden in Simulated Selfhost. I can't reproduce this organically, but I was able to do so by forcing the command palette to be empty.
miniksa
approved these changes
Feb 22, 2022
miniksa
added
the
AutoMerge
|
Hello @miniksa! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
zadjii-msft
approved these changes
Feb 22, 2022
ghost
merged commit
miniksa
pushed a commit
that referenced
this pull request
Mar 3, 2022
Fixes two crashes amounting to 14% of our crash burden in Simulated Selfhost. I can't reproduce this organically, but I was able to do so by forcing the command palette to be empty.
DHowett
added a commit
that referenced
this pull request
Mar 10, 2022
Fixes two crashes amounting to 14% of our crash burden in Simulated Selfhost. I can't reproduce this organically, but I was able to do so by forcing the command palette to be empty. (cherry picked from commit 30aa514)
|
🎉 Handy links: |
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two crashes amounting to 14% of our crash burden in Simulated
Selfhost. I can't reproduce this organically, but I was able to do so by
forcing the command palette to be empty.