Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Window Persistence" feature flag #12499

Merged
merged 2 commits into from
Feb 16, 2022
Merged

Remove "Window Persistence" feature flag #12499

merged 2 commits into from
Feb 16, 2022

Conversation

carlos-zamora
Copy link
Member

Removes the Feature_PersistedWindowLayout feature flag so that it's always enabled.

Closes #12422

@ghost ghost added Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Feb 16, 2022
@carlos-zamora
Copy link
Member Author

(if we want to keep the feature flag still, I can just revert that last commit. But I don't really understand a reason to do that, so figured I'd just remove it haha)

@DHowett DHowett closed this Feb 16, 2022
@DHowett DHowett reopened this Feb 16, 2022
@DHowett
Copy link
Member

DHowett commented Feb 16, 2022

I closed and reopened it to trigger the CLA bot, but it did not work...

@zadjii-msft
Copy link
Member

does CLA bot know something we don't 😅

zadjii-msft
zadjii-msft approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO alwaysEnabled==="we can just delete this now"

@DHowett
Copy link
Member

DHowett commented Feb 16, 2022

@zadjii-msft, did we agree that 1.13 or 1.14 would be the first public version with session save/restore? I forget.

@DHowett
Copy link
Member

DHowett commented Feb 16, 2022

AKA: do i backport this

@DHowett DHowett merged commit d36cb75 into main Feb 16, 2022
@DHowett DHowett deleted the dev/cazamor/1.14/window-persistence-flag branch February 16, 2022 23:37
DHowett
DHowett reviewed Feb 16, 2022
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOSP I APPROVE

@zadjii-msft
Copy link
Member

@DHowett IIRC you mentioned enabling this for 1.14 Stable (i.e. no backport). I didn't argue, but if it were up to me I'd turn it on in 1.13 Stable (backport). There's not really any bugfixes for this feature going in to 1.14, so keeping it in 1.14+ seems arbitrary. That's my 2c.

DHowett pushed a commit that referenced this pull request Mar 10, 2022
@carlos-zamora @DHowett
Remove "Window Persistence" feature flag (#12499)
3a42dc2 
Removes the `Feature_PersistedWindowLayout` feature flag so that it's always enabled.

Closes #12422

(cherry picked from commit d36cb75)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett left review comments

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move the window persistence velocity flag to enabled always
3 participants
@carlos-zamora @DHowett @zadjii-msft