Tell PublishSymbols task about binaries as well as the PDB files #11852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feed binaries into the indexer engine as well for improved symbol reliability while debugging, especially around thrown exceptions.
ghost
added
Area-Build
carlos-zamora
approved these changes
Dec 1, 2021
|
Oof. Problem. Have to exclude the packages folder for binaries... Or restrict the search paths to the bin directories or artifacts directories instead of matching everything... |
zadjii-msft
approved these changes
Dec 1, 2021
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
zadjii-msft
removed
the
AutoMerge
|
hold please still fixing stuff |
This comment has been minimized.
This comment has been minimized.
ghost
added
the
Issue-Bug
DHowett
approved these changes
Dec 1, 2021
miniksa
added
the
AutoMerge
ghost
merged commit
DHowett
pushed a commit
that referenced
this pull request
Dec 13, 2021
) We have been advised to give not only the PDB paths, but paths to the EXE and DLL files we produce, to the PublishSymbols build task. We are assured by our engineering systems teams that enlightening the task to all of this information helps it hook things up better somewhere between our build machine and the symbol server such that debugging is more robust, especially around thrown exception stacks. ## PR Checklist * [x] Closes #11737 - main fix for feeding EXEs and DLLs into the symbol publisher * [x] Closes #11860 - bonus fix because I noticed the PDB source linking wasn't working * [x] I work here. * [x] If it fits, it sits. (cherry picked from commit 52235b0)
DHowett
pushed a commit
that referenced
this pull request
Dec 13, 2021
) We have been advised to give not only the PDB paths, but paths to the EXE and DLL files we produce, to the PublishSymbols build task. We are assured by our engineering systems teams that enlightening the task to all of this information helps it hook things up better somewhere between our build machine and the symbol server such that debugging is more robust, especially around thrown exception stacks. ## PR Checklist * [x] Closes #11737 - main fix for feeding EXEs and DLLs into the symbol publisher * [x] Closes #11860 - bonus fix because I noticed the PDB source linking wasn't working * [x] I work here. * [x] If it fits, it sits. (cherry picked from commit 52235b0)
This was referenced Feb 4, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been advised to give not only the PDB paths, but paths to the EXE and DLL files we produce, to the PublishSymbols build task. We are assured by our engineering systems teams that enlightening the task to all of this information helps it hook things up better somewhere between our build machine and the symbol server such that debugging is more robust, especially around thrown exception stacks.
PR Checklist