Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabTests fail with AccessViolation as 0 is passed to _GetTerminalTabImpl #8167

Closed
Don-Vito opened this issue Nov 5, 2020 · 1 comment · Fixed by #8168
Closed

TabTests fail with AccessViolation as 0 is passed to _GetTerminalTabImpl #8167

Don-Vito opened this issue Nov 5, 2020 · 1 comment · Fixed by #8168
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@Don-Vito
Copy link
Contributor

Don-Vito commented Nov 5, 2020

Environment

Development

Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]
Windows Terminal version (if applicable):

Any other software?

No

Steps to reproduce

Run tests

Expected behavior

Tests succeed

Actual behavior

Tests fail

We have a small bug in tests, and I need a ticket number to push the fix.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 5, 2020
@Don-Vito Don-Vito mentioned this issue Nov 5, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Nov 5, 2020
@ghost ghost closed this as completed in #8168 Nov 5, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Nov 5, 2020
ghost pushed a commit that referenced this issue Nov 5, 2020
@Don-Vito
8167: Fix TabTests - use tab 0 rather than value 0 (#8168)
5de4f98 
A fix for UTs crashing due to bad memory access (accessing page 0).
Regression from #8153
Closes #8167
@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #8168, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

8167: Fix TabTests - use tab 0 rather than value 0 Don-Vito/terminal
1 participant
@Don-Vito