Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

At certain font sizes, ligatures only render in the rightmost cell #4806

Closed
DHowett-MSFT opened this issue Mar 5, 2020 · 0 comments · Fixed by #4861
Closed

At certain font sizes, ligatures only render in the rightmost cell #4806

DHowett-MSFT opened this issue Mar 5, 2020 · 0 comments · Fixed by #4861
Assignees
@miniksa
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@DHowett-MSFT
Copy link
Contributor

As of 0.10.641.0.

image

if i bump the font size up or down,

image
image
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 5, 2020
@DHowett-MSFT DHowett-MSFT added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. and removed Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 5, 2020
@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.0 milestone Mar 5, 2020
@DHowett-MSFT DHowett-MSFT added the Priority-1 A description (P1) label Mar 5, 2020
@DHowett-MSFT DHowett-MSFT mentioned this issue Mar 9, 2020
Closed
DHowett-MSFT pushed a commit that referenced this issue Mar 10, 2020
@DHowett
Suppress run breaking for abs. differences < 0.001 in advance
a0a593f 
With certain font faces at certain sizes, the advances seem to be
slightly more than the pixel grid; Cascadia Code at 13pt (though, 200%
scale) had an advance of 10.000001.

This commit makes it so that anything sub-1/100 of a cell won't make us
break up runs, because doing so results in suboptimal rendering.

Fixes #4806.
@DHowett-MSFT DHowett-MSFT mentioned this issue Mar 10, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Mar 10, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements and removed In-PR This issue has a related PR labels Mar 10, 2020
DHowett-MSFT pushed a commit that referenced this issue Mar 10, 2020
@DHowett
Suppress run breaking for abs. differences < 0.001 in advance (#4861)
d954ad6 
With certain font faces at certain sizes, the advances seem to be
slightly more than the pixel grid; Cascadia Code at 13pt (though, 200%
scale) had an advance of 10.000001.

This commit makes it so that anything sub-1/100 of a cell won't make us
break up runs, because doing so results in suboptimal rendering.

Fixes #4806.
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Mar 10, 2020
abhijeetviswam pushed a commit to abhijeetviswam/terminal that referenced this issue Mar 12, 2020
@DHowett @abhijeetviswam
Suppress run breaking for abs. differences < 0.001 in advance (micros…
68a2d94 
…oft#4861)

With certain font faces at certain sizes, the advances seem to be
slightly more than the pixel grid; Cascadia Code at 13pt (though, 200%
scale) had an advance of 10.000001.

This commit makes it so that anything sub-1/100 of a cell won't make us
break up runs, because doing so results in suboptimal rendering.

Fixes microsoft#4806.
@DHowett-MSFT DHowett-MSFT mentioned this issue Mar 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miniksa miniksa

Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Suppress run breaking for abs. differences < 0.001 in advance microsoft/terminal
2 participants
@DHowett-MSFT @miniksa