Be able to support clicking on embedded links in the mark mode #18310
Assignees
Labels
Area-Interaction
Interacting with the vintage console window (as opposed to driving via API or hooks)
In-PR
This issue has a related PR
Issue-Feature
Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Needs-Tag-Fix
Doesn't match tag requirements
Product-Terminal
The new Windows Terminal.
Milestone
Comments
StevenBucher98
added
the
Issue-Feature
microsoft-github-policy-service
bot
added
Needs-Tag-Fix
carlos-zamora
added
Area-Interaction
|
To navigate to a hyperlink using a keyboard (PR #13405)...
So yeah, we should navigate to the embedded links too |
carlos-zamora
removed
the
Needs-Triage
microsoft-github-policy-service
bot
added
the
Needs-Tag-Fix
DHowett
pushed a commit
that referenced
this issue
Feb 26, 2025
## Summary of the Pull Request
There's already logic to tab to a hyperlink when we're in mark mode. We
do this by looking at the automatically detected hyperlinks and finding
the next one of interest. This adds an extra step afterwards to find any
embedded hyperlinks and tab to them too.
Since embedded hyperlinks are stored as text attributes, we need to
iterate through the buffer to find the hyperlink and it's buffer
boundaries. This PR tries to reduce the workload of that by first
finding the automatically detected hyperlinks (since that's a fairly
quick process), then using the reduced search area to find the embedded
hyperlink (if one exists).
## Validation Steps Performed
In PowerShell, add an embedded hyperlink as such:
```powershell
${ESC}=[char]27
Write-Host "${ESC}]8;;https://github.com/microsoft/terminal${ESC}\This is a link!${ESC}]8;;${ESC}\"
```
Enter mark mode (ctrl+shift+m) then shift+tab to it.
✅ The "This is a link!" is selected
✅ Verified that this works when searching forwards and backwards
Closes #18310
Closes #15194
Follow-up from #13405
OSC 8 support added in #7251
(cherry picked from commit 35bd607)
Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgXBDb8
Service-Version: 1.23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the new feature
Currently from #13405 support for keyboard use of hyperlinks is supported but does not work for embedded links. For example, when a link is embedded and or does not have the
https://prefix it does not work. Here is a screenshot of scenario where the embedded links are not accessible via keyboard.Proposed technical implementation details
Make embedded links and links that do not have the https:// in the prefix available to be accessed by the mark mode.
The text was updated successfully, but these errors were encountered: