Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag list support to JDBC vector stores #243

Merged
merged 5 commits into from
Oct 23, 2024

Conversation

milderhc
Copy link
Member

@milderhc milderhc commented Oct 9, 2024

Motivation and Context

Description

Fixes: #240
Fixes: #242

Contribution Checklist

Copy link
Member

@dsgrieve dsgrieve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collections.unmodifiableList(tags) will throw a NPE if tags is null. The default constructor for Hotel passes null for tags.

A bigger question is why tags needs to be a copy. John asked only if it needs to be a copy. And why would tags be a copy and not the other lists?

@milderhc
Copy link
Member Author

Collections.unmodifiableList(tags) will throw a NPE if tags is null. The default constructor for Hotel passes null for tags.

A bigger question is why tags needs to be a copy. John asked only if it needs to be a copy. And why would tags be a copy and not the other lists?

I left it without copy. This Hotel class is only for integration tests anyways.

johnoliver
johnoliver previously approved these changes Oct 22, 2024
@milderhc milderhc merged commit 4fcab6a into microsoft:main Oct 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants