Merge pull request #291 from pjirsa/main

OpenTelemetry Semantic Convention compliance
microsoft · Mar 3, 2025 · bf4e93d · bf4e93d
2 parents 3c3b2e7 + 016aa22
commit bf4e93d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.../openai/src/test/java/com/microsoft/semantickernel/aiservices/openai/OtelCaptureTest.java b/.../openai/src/test/java/com/microsoft/semantickernel/aiservices/openai/OtelCaptureTest.java
@@ -118,9 +118,9 @@ public void otelChatCaptureTest() {
             spans.get(0).getAttributes().get(AttributeKey.stringKey("gen_ai.system")));
         Assertions.assertEquals(21,
             spans.get(0).getAttributes()
-                .get(AttributeKey.longKey("gen_ai.response.completion_tokens")));
+                .get(AttributeKey.longKey("gen_ai.usage.output_tokens")));
         Assertions.assertEquals(42,
             spans.get(0).getAttributes()
-                .get(AttributeKey.longKey("gen_ai.response.prompt_tokens")));
+                .get(AttributeKey.longKey("gen_ai.usage.input_tokens")));
     }
 }
diff --git a/...c/main/java/com/microsoft/semantickernel/implementation/telemetry/ChatCompletionSpan.java b/...c/main/java/com/microsoft/semantickernel/implementation/telemetry/ChatCompletionSpan.java
@@ -104,8 +104,8 @@ public void endSpanWithUsage(ChatCompletions chatCompletions) {
         CompletionsUsage usage = chatCompletions.getUsage();
         getSpan().setStatus(StatusCode.OK);
         getSpan()
-            .setAttribute("gen_ai.response.completion_tokens", usage.getCompletionTokens());
-        getSpan().setAttribute("gen_ai.response.prompt_tokens", usage.getPromptTokens());
+            .setAttribute("gen_ai.usage.output_tokens", usage.getCompletionTokens());
+        getSpan().setAttribute("gen_ai.usage.input_tokens", usage.getPromptTokens());
         close();
     }