Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new method #1

Closed
wants to merge 1 commit into from
Closed

Add new method #1

wants to merge 1 commit into from

Conversation

TheMysteriousStranger90
Copy link

Add new method which will allow to set or change a custom alphabet after instantiating the class. This can be useful for dynamically adjusting the encoding.

@TheMysteriousStranger90
Copy link
Author

@microsoft-github-policy-service agree

/// <remarks>
/// This method allows dynamic changes to the alphabet used for encoding and decoding data. Before setting a new alphabet, the method performs checks for duplicates and the presence of forbidden characters.
/// </remarks>
public void SetCustomAlphabet(string customAlphabet)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SetCustomAlphabet

Sorry for not noticing this PR earlier! This looks like a good idea. It'd be best to share the argument validated logic between this method and the constructor via a shared helper.

@@ -0,0 +1,13 @@
# Default ignored files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignored

maybe add .idea/ as well? you are an intellij user?

@TheMysteriousStranger90 TheMysteriousStranger90 closed this by deleting the head repository Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants