-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for react-native 0.71 #1199
Conversation
d720ae8
to
75bf6a2
Compare
929f8e3
to
9d1ecd0
Compare
ff5581e
to
b9e1134
Compare
b9e1134
to
07230c1
Compare
When upgrading to this version, please update your `build.gradle` to using `getReactNativeDependencies()`. This will reduce breakages when moving to 0.71 and beyond: ```diff diff --git a/example/android/build.gradle b/example/android/build.gradle index 984a681..29ef8ce 100644 --- a/example/android/build.gradle +++ b/example/android/build.gradle @@ -1,7 +1,6 @@ buildscript { def androidTestAppDir = "../node_modules/react-native-test-app/android" apply(from: "${androidTestAppDir}/dependencies.gradle") - apply(from: "${androidTestAppDir}/test-app-util.gradle") repositories { mavenCentral() @@ -9,12 +8,8 @@ buildscript { } dependencies { - classpath("com.android.tools.build:gradle:${androidPluginVersion}") - - def isNightly = getPackageVersionNumber("react-native", rootDir) == 0 - if (isNightly || isNewArchitectureEnabled(project)) { - classpath("com.facebook.react:react-native-gradle-plugin") - classpath("de.undercouch:gradle-download-task:5.3.0") + getReactNativeDependencies().each { dependency -> + classpath(dependency) } } } ```
07230c1
to
5469a1d
Compare
// Due to a bug in AGP, we have to explicitly set a dependency | ||
// between configureCMakeDebug* tasks and the preBuild tasks. This can | ||
// be removed once this issue is resolved: | ||
// https://issuetracker.google.com/issues/207403732 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems to be fixed in AGP 7.3.0-alpha9; since 0.71 uses AGP 7.3.1 should we have a separate if statement for 7100?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting with 7100, usePrefabs
is true, so we won't go into this path any longer. Eventually, we will just remove this branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, tested locally and seems to be working fine - left one minor comment but I think overall we can proceed ✅
Description
When upgrading to this version, please update your
build.gradle
to usinggetReactNativeDependencies()
. This will reduce breakages when moving to 0.71 and beyond:Resolves #1198.
Platforms affected
Test plan
Use the script to test 0.64, 0.68, 0.71, nightly:
When getting to Fabric builds, you will have to make changes to
App.js
sincereact-native-safe-area-context
is not yet compatible with latest new arch changes:Screenshots