Job submission #1479
Job submission #1479
Conversation
|
|
global.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "sdk": { | |||
| "version": "6.0.100", | |||
| "version": "6.0.300", | |||
There was a problem hiding this comment.
We're in the process of taking this change in another change. Do you need 6.0.300 in order for the changes to work? In any case, you should exclude this from the PR, even if locally you're using 6.0.300 for testing.
There was a problem hiding this comment.
I forgot to change back when troubleshooting job submission issues. Changes will work with 6.0.100
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "quantum-devkit-vscode", | |||
| "version": "#VSCODEVSIX_VERSION#", | |||
| "version": "0.9999.22060152", | |||
There was a problem hiding this comment.
Make sure that your v.template file keeps the #VSCODEVSIX_VERSION#. We can chat offline if you have questions about how this works.
There was a problem hiding this comment.
Gotcha, thanks would be great to hear about how it works.
| @@ -74,7 +119,7 @@ | |||
| "null" | |||
| ], | |||
| "description": "Path to the language server assembly for Q#.", | |||
| "default": null | |||
| "default": "C:/Users/t-jackmonas/work/qsharp-compiler/src/QsCompiler/LanguageServer/bin/Debug/net6.0/win10-x64/publish/Microsoft.Quantum.QsLanguageServer.exe" | |||
There was a problem hiding this comment.
Don't include this in the PR. It makes sense to change locally while you're developing, but it will help us avoid an accident if this never makes it to the repo.
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "optimizationProviders":["Microsoft"] | |||
There was a problem hiding this comment.
It would be better to exclude targets than providers, since Microsoft could later on add a QC target, or another provider could add an optimization one.
|
Let's make sure we get an official icon for the graphic used in this PR. For now, we can definitely use the one you included, but before the project is over, we could request one to be provided to us. |
…piler into job-submission
filter out optimization targets, by target not provider
job submission, listing, and pulling of results