Auto-import should suggest exact matches with higher priority

[matangover]

When showing code actions for Path, I get:

The fourth item is clearly the one I'm after, as it's an exact match to what I've typed. Personally I'm inclined to think code actions should not suggest 'fuzzy' auto-imports at all (e.g. it's very improbably that I'm looking to import pathccompiler from numpy.distutils). That is, I don't naturally expect auto-complete in code actions, only auto-import of what I've already typed. But my main suggestion is to show the most relevant option (exact match) on top or at least have it initially selected.

[jakebailey]

We're currently working on this (#97); by Path I'm assuming you are actually interested in pathlib.Path, correct? We don't offer values out of modules that we haven't already analyzed, so you'll only get the odd thing that has been analyzed, or mostly, module names.

I believe that this is going to be much, much improved in next week's release (though we're still tweaking things!).

[matangover]

Oh, that's great! I see two separate issues:

1. Values from unanalyzed modules do not show up. I was just about to report this: Add import Path from pathlib doesn't show up unless I type import pathlib manually first (causing the module to be analyzed). I understand I don't need to report this, as it's already being worked on.

2. As I wrote above: When the module is already analyzed, the ordering of the items is not intuitive (exact match doesn't come first). Is this also being worked on / improved in the next release?

Thanks!

[jakebailey]

We're aware of both of these things. I know that the former is what we've been focusing on (getting values), and after that the latter (filtering them and ordering the values now that we have them).

[matangover]

Great. Thanks.

[matangover]

P.S. I believe most other IDEs don't offer 'fuzzy' matches for auto-import, and this is why I'm surprised to see so many options in the dropdown. But as long as the best option is selected first, it doesn't matter that much.

[heejaechang]

should be fixed in the next version.

[heejaechang]

until we improve the memory/CPU issue with auto-indexing, you need "python.analysis.indexing": true in .vscode/settings.json for "add import/auto import" feature for third party libraries to be enabled.

[matangover]

This is still not fixed, can it be re-opened? I can still reproduce both issues 1 and 2 described above.

Issue 1:

Here sys should be shown but since it hasn't been analyzed yet (hasn't been manually imported), the auto-import suggestion are only showing results from the os module (which has been manually imported).

Using latest version Pylance language server 2021.8.2 (pyright f462f5bb)

[matangover]

Issue 2:

The exact match shows up last instead of first.

[jakebailey]

Set "python.analysis.indexing": true, and if it works, then it will work when we enable indexing for everyone.

[matangover]

Thanks for the info. That's great! I confirm that adding this setting fixes issue 1 when having a workspace folder opened. However, it's still not fixed when only a single file is opened (i.e. having no workspace folder open).

Also, it doesn't fix issue 2:

[jakebailey]

We'd appreciate new issues for each of these, if you could.

[matangover]

I can open a new issue for "issue 1 not fixed when single file is opened". For "issue 2 not fixed" this current issue should be reopened, since it is exactly that.

[jakebailey]

Yes, thanks. I didn't notice.

[heejaechang]

now, we always enable indexing on stdlib and fixed a bug on ranking that got broken when we did file path normalization.

[bschnurr]

This issue has been fixed in version 2022.1.1, which we've just released. You can find the changelog here: CHANGELOG.md