Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-import should sort suggestions better #279

Closed
nip3o opened this issue Aug 25, 2020 · 2 comments
Closed

Auto-import should sort suggestions better #279

nip3o opened this issue Aug 25, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@nip3o
Copy link

nip3o commented Aug 25, 2020

This is an example of an auto import suggestion from a Django project with a model called WorkPeriod. In this case we have an exact match (the correct import in this case), but it ends up really far down in the list. Naturally there are quite a few other things in the project that contains the name of that model, and it's probably reasonable to include all or most of them in the import suggestions, but the sorting should be improved.

Maybe there is also a difference between what import suggestions are relevant while typing, and what imports are relevant when "correcting squiggles". In this particular case I would find the non-exact-matches useful while typing/intellisense, but not while showing quick fixes.

image

@jakebailey jakebailey added the enhancement New feature or request label Aug 25, 2020
@github-actions github-actions bot removed the triage label Aug 25, 2020
@jakebailey
Copy link
Member

We're currently reworking this, but showing exact matches at the top sounds reasonable.

@heejaechang heejaechang self-assigned this Sep 2, 2020
@heejaechang
Copy link
Contributor

this is a dup of #297

tracking issue on the other issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants