Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting the text before anonymizing #890

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

shiranr
Copy link
Contributor

@shiranr shiranr commented Jul 3, 2022

Change Description

Fix the way we get the text for anonymization, get it from the original text and not from the anonymized one to make sure we are not overlapping with wrong text as in issue #888.

Issue reference

This PR fixes issue #888

Checklist

  • [ X ] I have reviewed the contribution guidelines
  • [ X ] I have signed the CLA
  • [ X ] My code includes unit tests
  • [ X ] All unit tests and lint checks pass locally
  • [ X ] My PR contains documentation updates / additions if required

Copy link
Contributor

@omri374 omri374 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@shiranr shiranr merged commit 87c62d9 into main Jul 5, 2022
@shiranr shiranr deleted the fix_bug_in_anonymizer_replacement_text branch July 5, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants