Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added fixes for a number of POH issues #2144

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Added fixes for a number of POH issues #2144

merged 3 commits into from
Jan 27, 2025

Conversation

mrsharm
Copy link
Contributor

@mrsharm mrsharm commented Jan 13, 2025 •
edited
Loading

Fixes #2024. CC: @Maoni0

@mrsharm mrsharm changed the title Fixes https://github.com/microsoft/perfview/issues/2024 Added fixes for a number of POH issues Jan 13, 2025
@mrsharm mrsharm changed the title Added fixes for a number of POH issues [NO MERGE] Added fixes for a number of POH issues Jan 14, 2025
@mrsharm mrsharm marked this pull request as ready for review January 14, 2025 22:10
@brianrob brianrob changed the title [NO MERGE] Added fixes for a number of POH issues Added fixes for a number of POH issues Jan 15, 2025
brianrob
brianrob approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@brianrob brianrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are you ready to merge @mrsharm?

Maoni0
Maoni0 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@Maoni0 Maoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think we can merge! thanks Moko.

@brianrob brianrob merged commit baa8c94 into microsoft:main Jan 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianrob brianrob brianrob approved these changes

@Maoni0 Maoni0 Maoni0 approved these changes

@cincuranet cincuranet Awaiting requested review from cincuranet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix the places where we are still using Gens.GenLargeObj incorrectly
3 participants
@mrsharm @brianrob @Maoni0