Merge pull request #41 from microsoft/fix/removeCharacters

fix: removes call to addcslashes in getStringValue() functions
microsoft · Feb 10, 2025 · f7097a1 · f7097a1
2 parents e145105 + de2e6d1
commit f7097a1
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/packages/serialization/form/src/FormParseNode.php b/packages/serialization/form/src/FormParseNode.php
@@ -73,7 +73,7 @@ public function getChildNode(string $identifier): ?FormParseNode
     public function getStringValue(): ?string
     {
         return is_string($this->node) && !$this->isNull()
-            ? urldecode(addcslashes($this->node, "\\\t\r\n"))
+            ? urldecode($this->node)
             : null;
     }
     /**

diff --git a/packages/serialization/json/src/JsonParseNode.php b/packages/serialization/json/src/JsonParseNode.php
@@ -53,7 +53,7 @@ public function getChildNode(string $identifier): ?ParseNode {
      * @inheritDoc
      */
     public function getStringValue(): ?string {
-        return is_string($this->jsonNode) ? addcslashes($this->jsonNode, "\\\r\n") : null;
+        return is_string($this->jsonNode) ? $this->jsonNode : null;
     }
 
     /**

diff --git a/packages/serialization/json/tests/JsonParseNodeTest.php b/packages/serialization/json/tests/JsonParseNodeTest.php
@@ -160,6 +160,15 @@ public function testGetStringValue(): void{
         $this->assertEquals('Silas Kenneth was here', $expected);
     }
 
+    /**
+     */
+    public function testGetStringValueWithSlashAndWhitespace(): void
+    {
+        $this->parseNode = new JsonParseNode('\ This is a test with a tab at then and slash at the beginning \t.');
+        $expected = $this->parseNode->getStringValue();
+        $this->assertEquals('\ This is a test with a tab at then and slash at the beginning \t.', $expected);
+    }
+
     public function testGetChildNode(): void {
         $this->stream->rewind();
         $this->parseNode = (new JsonParseNodeFactory())->getRootParseNode('application/json', $this->stream);