[728-1] Runner calculates MD5 checksum for uploads. #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BMurri
approved these changes
Jun 14, 2024
| @@ -49,7 +49,7 @@ public static string CalculateMd5(string file) | |||
| using var md5 = MD5.Create(); | |||
| using var stream = File.OpenRead(file); | |||
| var hash = md5.ComputeHash(stream); | |||
| return Convert.ToBase64String(hash); | |||
| return BitConverter.ToString(hash).Replace("-", "").ToLowerInvariant(); | |||
There was a problem hiding this comment.
Consider Encoding.UTF8.GetString
|
|
||
| Logger.LogInformation("MD5 hash calculated for file: {filePath}.", filePath); | ||
|
|
||
| return BitConverter.ToString(hash).Replace("-", "").ToLowerInvariant(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies to #728
In this PR:
RuntimeOptions.SetContentMd5OnUpload. When set totrue, the runner will compute the MD5 for the files before the block list is committed.Pending Work (to complete: #728):
false.