Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set AzureCloudName when deploying upgrades when not previously set #722

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Set AzureCloudName when deploying upgrades when not previously set #722

merged 1 commit into from
Jun 11, 2024

Conversation

BMurri
Copy link
Collaborator

@BMurri BMurri commented Jun 11, 2024

fixes #721

@BMurri BMurri requested a review from MattMcL4475 June 11, 2024 20:05
@MattMcL4475
Copy link
Collaborator

do need this in the CoA deployer too?

@BMurri
Copy link
Collaborator Author

BMurri commented Jun 11, 2024

do need this in the CoA deployer too?

I effectively copied this fix from the CoA deployer (that's the reason this issue didn't present there)

@BMurri BMurri merged commit f2861e2 into main Jun 11, 2024
7 checks passed
@BMurri BMurri deleted the bmurri/deploy-upgrade-stall branch June 11, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattMcL4475 MattMcL4475 MattMcL4475 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrading TES deployment results in TES boot loop (failure to start)
2 participants
@BMurri @MattMcL4475