Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pursue more efficient effective intra-task compute node cleanup #712

Merged
merged 3 commits into from
May 21, 2024
Merged

Pursue more efficient effective intra-task compute node cleanup #712

merged 3 commits into from
May 21, 2024

Conversation

BMurri
Copy link
Collaborator

@BMurri BMurri commented May 20, 2024 •
edited
Loading

fixes #713

@BMurri BMurri added enhancement New feature or request Performance Enable users can run task as cheap and as fast as possible Robustness Enable users can run tasks w/o bugs or with mitigation of known bugs Scalability Enable users can scale TES workloads labels May 20, 2024
@BMurri BMurri added this to the next milestone May 20, 2024
@BMurri BMurri requested review from giventocode and MattMcL4475 May 20, 2024 22:31
@BMurri BMurri self-assigned this May 20, 2024
MattMcL4475
MattMcL4475 approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@MattMcL4475 MattMcL4475 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add an issue and a PR description of how this fixes/improves things? After merge, can you also update CoA and run the common workflows?

@BMurri BMurri removed enhancement New feature or request Performance Enable users can run task as cheap and as fast as possible Robustness Enable users can run tasks w/o bugs or with mitigation of known bugs Scalability Enable users can scale TES workloads labels May 21, 2024
@BMurri BMurri removed this from the next milestone May 21, 2024
@BMurri BMurri removed their assignment May 21, 2024
@BMurri BMurri merged commit b9a39c7 into main May 21, 2024
9 checks passed
@BMurri BMurri deleted the bmurri/efficient-node-cleanup branch May 21, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattMcL4475 MattMcL4475 MattMcL4475 approved these changes

@giventocode giventocode Awaiting requested review from giventocode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pursue more efficient effective intra-task compute node cleanup
2 participants
@BMurri @MattMcL4475