Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App insights key lookup occurs only when configuration option is set #69

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

giventocode
Copy link
Contributor

Closes #68

  • This PR modifies the start-up logic so it only performs the look up of the app insights key/connection string if the app insights configuration is provided.
  • If not provided the default configuration is used - documentation here.

@giventocode giventocode merged commit 4515180 into develop Feb 7, 2023
@giventocode giventocode deleted the ja/app-insights-key branch February 7, 2023 01:02
vsmalladi added a commit that referenced this pull request May 20, 2024
* Add in 1.1.0 TES spec compliance.

* Add in both versions of of TES compliance ( 1.1 and 1.0 )

* Make two reports and concatenate them

* Updated TES compliance suite to update the service info testing for email PR: Update schema to match pattern of contact form or email. Closes #69. elixir-cloud-aai/openapi-test-runner#70 . This now allows our service info to pass for 1.0 and 1.1 compliance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App insights integration performs a management operation when running in production
2 participants