Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[347] Container SAS token is generated for internal TES URLs #348

Merged
merged 2 commits into from
Aug 9, 2023
Merged

[347] Container SAS token is generated for internal TES URLs #348

merged 2 commits into from
Aug 9, 2023

Conversation

giventocode
Copy link
Contributor

@giventocode giventocode commented Aug 9, 2023 •
edited
Loading

Fixes: #347

This PR includes:

  • Terra storage provide generates a container token when the blobPath is not set (empty) when generating TES internal URLs.

@giventocode giventocode merged commit b0ae6e8 into main Aug 9, 2023
@giventocode giventocode deleted the ja-container-sas branch August 9, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattMcL4475 MattMcL4475 MattMcL4475 approved these changes

@BMurri BMurri Awaiting requested review from BMurri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The SAS token for the cloud task file output fails in Terra
2 participants
@giventocode @MattMcL4475